- Notifications
You must be signed in to change notification settings - Fork142
Add rudimentary support for _tkinter in GraalPy#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter.Before use, the bindings need to be built using tklib_build.py.The code was modified from existing code in PyPy's main branch.Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons.It seems like there is a bug in the `cffi` module causing a SegFault.macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled.Windows was not tested.Co-authored-by: Margarete Dippel <margarete.dippel@student.hpi.de>Co-authored-by: Tim Felgentreff <tim.felgentreff@oracle.com>
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, pleasecreate an Oracle account and sign the OCA inOracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the mainOracle GitHub organization, and yourmembership in this organization is public. |
This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter. Before use, the bindings need to be built using tklib_build.py. The code was modified from existing code in PyPy's main branch.
Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons. It seems like there is a bug in the
cffimodule causing a SegFault. macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled. Windows was not tested.Tests
Running CPython's tests for
tkinterandttkshows some success, but some tests still fail, raise an error or even crash with a segmentation fault:The main culprit for the failing tests seem to be Unicode errors, PyPy's 3.8 branch seems to fix those.