NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.7k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Simplify type annotations for`tests/pruners_tests/test_percentile.py`#5808

Merged

nzw0301 merged 1 commit intooptuna:masterfromboringbyte:fix/test_percentile.py

Dec 1, 2024

Merged

Simplify type annotations for`tests/pruners_tests/test_percentile.py`#5808

nzw0301 merged 1 commit intooptuna:masterfromboringbyte:fix/test_percentile.py

Dec 1, 2024

Conversation

Copy link

Contributor

boringbyte commentedNov 30, 2024

Motivation

This PR aims to enhance type annotation handling inOptuna to the moduletests/pruners_tests/test_percentile.py and contributes to solving#4508.

Description of the changes

Apply changes totests/pruners_tests/test_percentile.py by replacingList andTuple fromtyping module.

fix type annotations for 'tests/pruners_tests/test_percentile.py'

4db64ec

Copy link

codecovbot commentedNov 30, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base(feb9d0b) to head(4db64ec).
Report is 355 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@##           master    #5808   +/-   ##=======================================  Coverage   89.53%   89.53%           =======================================  Files         199      199             Lines       12992    12992           =======================================+ Hits        11632    11633    +1+ Misses       1360     1359    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.