NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit0d82dff

committed

in ddim, noise should be predicted after x0 is maybe clipped, thanks to@lukovnikov for pointing this out in another repository

1 parent8bbc956 commit0d82dffCopy full SHA for 0d82dff

File tree

2 files changed

+24

-6

lines changed

dalle2_pytorch
- dalle2_pytorch.py
- version.py

2 files changed

+24

-6

lines changed

`‎dalle2_pytorch/dalle2_pytorch.py‎`

Lines changed: 23 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1281,19 +1281,28 @@ def p_sample_loop_ddim(self, shape, text_cond, *, timesteps, eta = 1., cond_scal`
`1281`	`1281`
`1282`	`1282`	`pred=self.net.forward_with_cond_scale(image_embed,time_cond,self_cond=self_cond,cond_scale=cond_scale,**text_cond)`
`1283`	`1283`
	`1284`	`+# derive x0`
	`1285`	`+`
`1284`	`1286`	`ifself.predict_x_start:`
`1285`	`1287`	`x_start=pred`
`1286`		`-pred_noise=self.noise_scheduler.predict_noise_from_start(image_embed,t=time_cond,x0=pred)`
`1287`	`1288`	`else:`
`1288`		`-x_start=self.noise_scheduler.predict_start_from_noise(image_embed,t=time_cond,noise=pred)`
`1289`		`-pred_noise=pred`
	`1289`	`+x_start=self.noise_scheduler.predict_start_from_noise(image_embed,t=time_cond,noise=pred_noise)`
	`1290`	`+`
	`1291`	`+# clip x0 before maybe predicting noise`
`1290`	`1292`
`1291`	`1293`	`ifnotself.predict_x_start:`
`1292`	`1294`	`x_start.clamp_(-1.,1.)`
`1293`	`1295`
`1294`	`1296`	`ifself.predict_x_startandself.sampling_clamp_l2norm:`
`1295`	`1297`	`x_start=self.l2norm_clamp_embed(x_start)`
`1296`	`1298`
	`1299`	`+# predict noise`
	`1300`	`+`
	`1301`	`+ifself.predict_x_start:`
	`1302`	`+pred_noise=self.noise_scheduler.predict_noise_from_start(image_embed,t=time_cond,x0=x_start)`
	`1303`	`+else:`
	`1304`	`+pred_noise=pred`
	`1305`	`+`
`1297`	`1306`	`iftime_next<0:`
`1298`	`1307`	`image_embed=x_start`
`1299`	`1308`	`continue`
`@@ -2897,16 +2906,25 @@ def p_sample_loop_ddim(`
`2897`	`2906`
`2898`	`2907`	`pred,_=self.parse_unet_output(learned_variance,unet_output)`
`2899`	`2908`
	`2909`	`+# predict x0`
	`2910`	`+`
`2900`	`2911`	`ifpredict_x_start:`
`2901`	`2912`	`x_start=pred`
`2902`		`-pred_noise=noise_scheduler.predict_noise_from_start(img,t=time_cond,x0=pred)`
`2903`	`2913`	`else:`
`2904`	`2914`	`x_start=noise_scheduler.predict_start_from_noise(img,t=time_cond,noise=pred)`
`2905`		`-pred_noise=pred`
	`2915`	`+`
	`2916`	`+# maybe clip x0`
`2906`	`2917`
`2907`	`2918`	`ifclip_denoised:`
`2908`	`2919`	`x_start=self.dynamic_threshold(x_start)`
`2909`	`2920`
	`2921`	`+# predict noise`
	`2922`	`+`
	`2923`	`+ifpredict_x_start:`
	`2924`	`+pred_noise=noise_scheduler.predict_noise_from_start(img,t=time_cond,x0=pred)`
	`2925`	`+else:`
	`2926`	`+pred_noise=pred`
	`2927`	`+`
`2910`	`2928`	`c1=eta* ((1-alpha/alpha_next)* (1-alpha_next)/ (1-alpha)).sqrt()`
`2911`	`2929`	`c2= ((1-alpha_next)-torch.square(c1)).sqrt()`
`2912`	`2930`	`noise=torch.randn_like(img)ifnotis_last_timestepelse0.`

`‎dalle2_pytorch/version.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-__version__='1.10.4'`
	`1`	`+__version__='1.10.5'`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0d82dff

File tree

2 files changed

2 files changed

`‎dalle2_pytorch/dalle2_pytorch.py‎`

`‎dalle2_pytorch/version.py‎`

0 commit comments