- Notifications
You must be signed in to change notification settings - Fork237
removing tombstones#3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
removing tombstones#3013
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
csviri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added some comments to fill in some details, refine naming.
But otherwise this looks awesome! thank you!
| returnthis; | ||
| } | ||
| publicBuilder<R>parseResourceVersionsForEventFilteringAndCaching(booleanparse) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
comparableResourceVersions we should probably have this also aswithComparableResourceVersions(boolean) that is a more generic name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I did this to be consistent with the other configuration for now. I can use a different name to start with here, or we can use a follow-up issue on how to approach the renaming in general.
| privatePrimaryToSecondaryMapper<?>primaryToSecondaryMapper; | ||
| privateSecondaryToPrimaryMapper<R>secondaryToPrimaryMapper; | ||
| privateKubernetesClientkubernetesClient; | ||
| privatebooleancomparableResourceVersions =true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should add this also to@KubernetesDependent annotation.
| log.debug("Resource found in cache: {} for id: {}",res.isPresent(),resourceID); | ||
| returnres; | ||
| } | ||
| log.debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it make sense also to log ifparseResourceVersions is true/false? But that might be trivial to see.
| publicOptional<String>getLastSyncResourceVersion(Optional<String>namespace) { | ||
| returngetSource(namespace.orElse(WATCH_ALL_NAMESPACES)) | ||
| .map(source ->source.getLastSyncResourceVersion()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: can be replaced by methode reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, this can be removed - see#3015
| .getResourceVersion() | ||
| .equals(previousResourceVersion)) | ||
| ||isLaterResourceVersion(resourceId,newResource,cachedResource))) { | ||
| // first check against the source in general - this also prevents resurrecting resources when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you pls expand the comment, and explain more in details (maybe sequence of events) how this prevents resurrection ?
Uh oh!
There was an error while loading.Please reload this page.
Replaces:#2989 to target v5.3
Adds per informer configuration and uses the configuration for the primary resource.
Probably superceded by :#3015 - at the very least some changes from there are needed here.