Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] feat: experimental utility methods to add finalizer#2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
csviri wants to merge10 commits intomain
base:main
Choose a base branch
Loading
fromnew-finalizer-add

Conversation

@csviri
Copy link
Collaborator

@csviricsviri commentedSep 17, 2025
edited
Loading

Improved way to add finalizers:

  • Gets the resource on retry from informer cache not a separate API call, so reduces the number of Kubernetes API calls
  • Caches the updated resource, making sure it is available for next reconiliation

TODO:

  • check if finalizer already there when retrying
  • discuss: have this as default way of adding finalizers (behind feature flag?)

csviriand others added9 commitsSeptember 2, 2025 13:15
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
this was added to fabric8 client meanwhileSigned-off-by: Attila Mészáros <a_meszaros@apple.com>
)* feature: add AggregatedMetrics to support multiple Metrics implementationsSigned-off-by: David Sondermann <david.sondermann@hivemq.com>
)Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-ciopenshift-cibot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelSep 17, 2025
@csviricsviri changed the base branch frommain tonextSeptember 17, 2025 11:27
@csviricsviri changed the titlenew finalizer add feat: experimental utility methods to add finalizerSep 17, 2025
@csviricsviri changed the title feat: experimental utility methods to add finalizer [WIP] feat: experimental utility methods to add finalizerSep 17, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@openshift-merge-robotopenshift-merge-robot added the needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD. labelOct 16, 2025
@csviricsviriforce-pushed thenext branch 2 times, most recently from3075f11 to4972764CompareOctober 23, 2025 13:17
@csviricsviriforce-pushed thenext branch 2 times, most recently from09f7950 to26de0d2CompareNovember 25, 2025 12:15
Base automatically changed fromnext tomainNovember 25, 2025 14:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csviri@openshift-merge-robot@Donnerbart@xstefank@metacosm

[8]ページ先頭

©2009-2025 Movatter.jp