- Notifications
You must be signed in to change notification settings - Fork237
refactor: static usage of junit extension#2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
| publicstaticfinalStringRESOURCE_NAME2 ="test2"; | ||
| @RegisterExtensionLocallyRunOperatorExtensionoperator =buildOperator(); | ||
| @RegisterExtensionLocallyRunOperatorExtensionextension =buildOperator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this one not static?
...operatorsdk/operator/dependent/primarytosecondaydependent/PrimaryToSecondaryDependentIT.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| additionalCustomResourceDefinitions.forEach(this::applyCrd); | ||
| for (varref :reconcilers) { | ||
| this.operator =newOperator(configurationServiceOverrider); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This shouldn't be done in the loop as the operator is re-initialized for each reconciler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hi@metacosm this is wip, pls ignore the PR while not marked ready
openshift-merge-robot commentedAug 6, 2025
PR needs rebase. Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. |
Signed-off-by: Attila Mészárosa_meszaros@apple.com