Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: update configuration service when overriding configuration#2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
metacosm wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromupdate-configuration-registration

Conversation

@metacosm
Copy link
Collaborator

Signed-off-by: Chris Laprunclaprun@redhat.com

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosmmetacosm self-assigned thisMay 7, 2025
@metacosmmetacosm requested review fromcsviri andxstefankMay 7, 2025 06:50
@openshift-ciopenshift-cibot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelMay 7, 2025
@metacosm
Copy link
CollaboratorAuthor

Currently, the configuration information related to a reconciler can be inconsistent between what's returned by theConfigurationService and what can be returned byRuntimeInfo fromRegisteredController (which should be the correct version, in case they differ). The problem isRuntimeInfo is not very well known and not as widely used asConfigurationService, which means that users can observe outdated configuration.

@openshift-merge-robotopenshift-merge-robot added the needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD. labelSep 26, 2025
@openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@csviri
Copy link
Collaborator

How can be that outdated, if it is immutable?

@csviri
Copy link
Collaborator

Note that only change that now allow in runtime is changing watched namespaces throughRegisteredController. After start no configuration other than this should be allowed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xstefankxstefankxstefank approved these changes

@csviricsviriAwaiting requested review from csviri

Assignees

@metacosmmetacosm

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@metacosm@openshift-merge-robot@csviri@xstefank
[8]ページ先頭
©2009-2025 Movatter.jp