- Notifications
You must be signed in to change notification settings - Fork235
-
Just wanted to make sure we're all on the same page with the proposed behavior of the JOSDK moving forward - that is it will use a dummy resourceVersion on a SSA create to simulate the atomic affect of a regular create. We had ultimately decided against this in keycloak, but it sound like we'll pick it up from the operator sdk instead. The major con of this approach, which exists also for regular JOSDK creates, is that an existing resource that lacks an owner reference will block any further reconciliation util it is deleted or has an owner reference added. |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 1 comment 5 replies
-
I think that for generic create operations (unlike the admin Secret in Keycloak) it might make more sense to block the reconciliation if a foreign resource exists. After all, as mentioned, this approach is aligned with the non-SSA create action. |
BetaWas this translation helpful?Give feedback.
All reactions
-
After this changehttps://github.com/operator-framework/java-operator-sdk/pull/1994/files#diff-aa20588ab4b1ff4f171a897d4042d1b055c02737b067d09aaeb9cfd770adf3a0R133 it will affect the admin Secret as well. |
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
@csviri also mentioned possibly making the action configurable - it could be one of "use existing" (as-is without adding an owner reference - the old KeycloakAdminSecret behavior), assume ownership (how the other KeyCloak OperatorManagedResources functioned), or fail. |
BetaWas this translation helpful?Give feedback.
All reactions
-
It makes sense to me to have this configurable. 👍 |
BetaWas this translation helpful?Give feedback.
All reactions
-
created an issue:#1999 before v5 there will be a small v4.5 release probably, if not objections / you don't require this earlier, it will be released only there. |
BetaWas this translation helpful?Give feedback.
All reactions
-
@csviri If that means#1994 and#1999 will be released together, that works for us. In any case, we're not targeting the switch to the dependent resources in Keycloak 22. It's for future 23. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 2