Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bug [2099580] - This fix will take care of deletion part of CR in java Operator.#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
laxmikantbpandhare merged 2 commits intooperator-framework:mainfromlaxmikantbpandhare:bug-fix-2099580
Jul 22, 2022
Merged

Conversation

@laxmikantbpandhare
Copy link
Member

This will fix the bug from Bugzilla - 2099580

I created issue#94 this also get fixed after the merge of this PR.

Copy link
Collaborator

@everettraveneverettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@laxmikantbpandhare Could we also update the sample in thetestdata/ directory so that our sample is up to date with our tutorial?

laxmikantbpandhare reacted with thumbs up emoji
@laxmikantbpandhare
Copy link
MemberAuthor

Sure@everettraven thanks for pointing out

Copy link
Collaborator

@everettraveneverettraven left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/lgtm

holding until PR title is updated to match format ofBug xxxxxx: summary as mentioned by@jmrodri offline
/hold

@openshift-ciopenshift-cibot added the do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command. labelJul 22, 2022
@openshift-ciopenshift-cibot added the lgtmIndicates that a PR is ready to be merged. labelJul 22, 2022
@laxmikantbpandharelaxmikantbpandhare changed the titlebig fix for deletion Custom resourceBug [2099580] - Deployment is not deleted when CR is deleted in Java operatorJul 22, 2022
@laxmikantbpandharelaxmikantbpandhare changed the titleBug [2099580] - Deployment is not deleted when CR is deleted in Java operatorBug [2099580] - This fix will take care of deletion part of CR in java Operator.Jul 22, 2022
@everettraven
Copy link
Collaborator

/hold cancel

@openshift-ciopenshift-cibot removed the do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command. labelJul 22, 2022
@laxmikantbpandharelaxmikantbpandhare merged commite4aed38 intooperator-framework:mainJul 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@everettraveneverettraveneverettraven approved these changes

@jmrodrijmrodriAwaiting requested review from jmrodri

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug [2099580] - Deployment is not deleted when CR is deleted in Java operator

2 participants

@laxmikantbpandhare@everettraven
[8]ページ先頭
©2009-2025 Movatter.jp