- Notifications
You must be signed in to change notification settings - Fork25
OCPBUGS-3469: Multi-arch support#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
everettraven left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These changes currently don't work when attempting to initialize a project usingoperator-sdk init .... I left a comment showing the error I received and what I think the solution is.
Another thing I noticed is there is a few commits with multiple contributors and looks like it would re-commit a few already merged commits. I think agit rebase (or similar operation) may have gone a bit off the rails as I would have only expected the Makefile template and the testdata to be updated by this PR.
Uh oh!
There was an error while loading.Please reload this page.
86f6323 to8816187CompareSigned-off-by: Catherine Chan-Tse <cchantse@redhat.com>
laxmikantbpandhare left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/lgtm
I will try updated tutorial steps on the weekend.
everettraven commentedMar 9, 2023
So I think the changes look good and make sense, but I just can't seem to get an image to actually be built when running |
everettraven left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/lgtm
Add configurable multi-arch build support