- Notifications
You must be signed in to change notification settings - Fork25
bump k8s 1.25 and kb versions#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bump k8s 1.25 and kb versions#103
Uh oh!
There was an error while loading.Please reload this page.
Conversation
laxmikantbpandhare commentedSep 19, 2022
will look into errors once I am back. |
jmrodri commentedSep 19, 2022
@laxmikantbpandhare do we need to update the actual java portions for 1.25?https://github.com/operator-framework/java-operator-plugins/blob/main/pkg/quarkus/v1alpha/scaffolds/internal/templates/pomxml.go#L53-L62 |
jmrodri commentedSep 19, 2022
You will also need to update the github action as part of this PRhttps://github.com/operator-framework/java-operator-plugins/blob/main/.github/workflows/test-unit.yml#L12 That needs to move to go 1.19 |
jmrodri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to update github action as part of this PR. And I left a question regarding the scaffold pom.
everettraven commentedSep 20, 2022
It also does not seem like Kubebuilder has been updated to have dependencies on K8s 1.25 as of that commit. I am planning to update this so this PR may need to be held until that is updated |
laxmikantbpandhare commentedSep 26, 2022
@everettraven@jmrodri - Updated all the dependencies according to suggestions. PTAL |
everettraven left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changes look good to me. I would wait to merge until signoff from@jmrodri as well.
jmrodri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/lgtm
bump k8s 1.25 and kb versions