Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: should show expired at status column#9584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nikhilsaikethe merged 1 commit intobranch-v0.30.0fromfix/missing-code
Dec 10, 2025

Conversation

@nikhilsaikethe
Copy link
Contributor

No description provided.

greptile-apps[bot] reacted with thumbs up emoji
@nikhilsaikethenikhilsaikethe merged commit2928303 intobranch-v0.30.0Dec 10, 2025
14 checks passed
@nikhilsaikethenikhilsaikethe deleted the fix/missing-code branchDecember 10, 2025 11:38
@github-actionsgithub-actionsbot added the ☢️ BugSomething isn't working labelDec 10, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

Fixed the license status display in the About page to correctly show whether a license is expired or active.

Key Changes:

  • Changed status badge logic from checking non-existentlicenseData.license.active to usinglicenseData?.expired field that's actually returned by the API
  • Updated badge color: red for expired licenses, green for active licenses
  • Changed status text from "Active/Inactive" to "Active/Expired" for clearer communication
  • Removed duplicate "Expired" badge from the expires_at row (it was redundant since status already shows this)

Impact:
The fix resolves a bug where the license status was not displaying correctly because the code was checking a field (license.active) that doesn't exist in the API response. The backend returns anexpired boolean at the root level of the response, which is now being used correctly.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are straightforward bug fixes that align the frontend code with the actual API response structure. The fix correctly uses theexpired field from the API response instead of the non-existentlicense.active field, and removes redundant UI elements. No breaking changes, no security concerns, and the logic is simple and correct.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
web/src/views/About.vue5/5Fixed license status display to useexpired field from API response instead of non-existentlicense.active field, and removed duplicate expired badge from expires_at row

Sequence Diagram

sequenceDiagram    participant User    participant AboutPage as About.vue    participant API as License API    participant Backend as License Handler    User->>AboutPage: Navigate to About page    activate AboutPage        AboutPage->>AboutPage: Check config (isEnterprise && !isCloud)        alt Enterprise & Self-hosted        AboutPage->>API: GET /api/license        activate API        API->>Backend: get_license_info()        activate Backend        Backend->>Backend: get_license()        Backend->>Backend: license_expired()        Backend->>Backend: ingestion_used()        Backend-->>API: LicenseResponse {expired, license, ...}        deactivate Backend        API-->>AboutPage: response.data        deactivate API                AboutPage->>AboutPage: Update licenseData with response        AboutPage->>AboutPage: Display status badge using licenseData?.expired                alt License Expired            AboutPage->>User: Show "Expired" badge (red)        else License Active            AboutPage->>User: Show "Active" badge (green)        end    else Not Enterprise or Cloud        AboutPage->>User: Show page without license section    end        deactivate AboutPage
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings |Greptile

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ BugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nikhilsaikethe

[8]ページ先頭

©2009-2025 Movatter.jp