Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Reset fields list pagination on stream change#9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@omkarK06
Copy link
Contributor

No description provided.

greptile-apps[bot] reacted with thumbs up emoji
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actionsgithub-actionsbot added the ☢️ BugSomething isn't working labelDec 10, 2025
@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

AddedresetPagination() calls to both stream selection handlers (handleMultiStreamSelection andhandleSingleStreamSelect) to reset the fields list pagination when the user changes streams.

  • Fixes issue where pagination state persisted after stream changes, showing stale page numbers
  • Consistent with existing pagination reset patterns used intoggleSchema() andtoggleInterestingFields()
  • Also exportsresetPagination from setup return to make it accessible from methods

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple, focused fix that adds pagination reset calls to stream selection handlers, following existing patterns in the codebase. No logic changes or risky modifications.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
web/src/plugins/logs/IndexList.vue5/5AddedresetPagination() calls to stream selection handlers to fix pagination state on stream changes

Sequence Diagram

sequenceDiagram    participant User    participant StreamSelect as Stream Select Dropdown    participant Handler as Selection Handler    participant Pagination as Pagination State    participant FieldList as Field List Component        User->>StreamSelect: Select/change stream(s)    StreamSelect->>Handler: handleMultiStreamSelection() or handleSingleStreamSelect()    Handler->>Handler: Clear filter input via $nextTick    Handler->>Handler: Call onStreamChange("")    Handler->>Pagination: Call resetPagination()    Pagination->>Pagination: Set page to 1    Pagination->>FieldList: Scroll to top via nextTick    FieldList-->>User: Display fields from page 1
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings |Greptile

@omkarK06omkarK06 merged commit4b01421 intobranch-v0.30.0Dec 10, 2025
38 checks passed
@omkarK06omkarK06 deleted the fix/reset-field-list-pagination-v0.30.0 branchDecember 10, 2025 10:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bjp232004bjp232004bjp232004 approved these changes

+1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ BugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omkarK06@bjp232004

[8]ページ先頭

©2009-2025 Movatter.jp