Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: do not show patterns in OSS stream settings#9537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
uddhavdave merged 1 commit intobranch-v0.30.0fromud/fix-sdr-stream-settings
Dec 9, 2025

Conversation

@uddhavdave
Copy link
Contributor

No description provided.

greptile-apps[bot] reacted with thumbs up emoji
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actionsgithub-actionsbot added the ☢️ BugSomething isn't working labelDec 9, 2025
@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

Hides the regex patterns column in the stream settings schema table for OSS builds by addingconfig.isEnterprise == 'true' checks. The changes ensure that:

  • The "patterns" column is only included in the table columns array for enterprise builds using spread operator conditional logic
  • The patterns cell template only renders interactive content (pattern counts and "Add Pattern" link) for enterprise builds
  • OSS builds display an empty cell instead of the patterns functionality

This prevents OSS users from seeing enterprise-only features in the stream settings UI.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI conditional rendering using a well-established pattern (config.isEnterprise == 'true') that's consistently used throughout the codebase. The implementation correctly hides both the column definition and the cell template content, ensuring no functionality leaks to OSS builds.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
web/src/components/logstream/schema.vue5/5Conditionally hides patterns column and cells in stream settings for OSS builds usingconfig.isEnterprise check

Sequence Diagram

sequenceDiagram    participant User    participant SchemaVue as Schema.vue    participant Config as config (aws-exports)    participant QTable as Quasar Table        User->>SchemaVue: View stream settings    SchemaVue->>Config: Check config.isEnterprise    Config-->>SchemaVue: Returns 'true' or 'false'        alt Enterprise Build (isEnterprise == 'true')        SchemaVue->>QTable: Include patterns column in columns array        SchemaVue->>QTable: Render patterns cell with pattern data        QTable-->>User: Show patterns column with clickable cells    else OSS Build (isEnterprise != 'true')        SchemaVue->>QTable: Exclude patterns column from columns array        SchemaVue->>QTable: Render empty cell for patterns slot        QTable-->>User: Hide patterns column    end
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings |Greptile

@uddhavdaveuddhavdave merged commite0ca0b9 intobranch-v0.30.0Dec 9, 2025
38 checks passed
@uddhavdaveuddhavdave deleted the ud/fix-sdr-stream-settings branchDecember 9, 2025 13:49
@uddhavdaveuddhavdave added this to thev0.30.0 milestoneDec 10, 2025
@uddhavdaveuddhavdave added the Needs-TestingNeeds-Testing labelDec 10, 2025
@priyabrata-stackpriyabrata-stack added Testing-CompletedTesting-Completed and removed Needs-TestingNeeds-Testing labelsDec 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nikhilsaikethenikhilsaikethenikhilsaikethe approved these changes

+1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ BugSomething isn't workingTesting-CompletedTesting-Completed

Projects

None yet

Milestone

v0.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@uddhavdave@nikhilsaikethe@priyabrata-stack

[8]ページ先頭

©2009-2025 Movatter.jp