Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: navigate to license button in about section#9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nikhilsaikethe merged 1 commit intobranch-v0.20.0fromfix/issue-9478-20.0
Dec 4, 2025

Conversation

@nikhilsaikethe
Copy link
Contributor

This PR fixes the issue in#9478

greptile-apps[bot] reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the ☢️ BugSomething isn't working labelDec 4, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@nikhilsaikethenikhilsaikethe merged commitbb0a180 intobranch-v0.20.0Dec 4, 2025
16 of 18 checks passed
@nikhilsaikethenikhilsaikethe deleted the fix/issue-9478-20.0 branchDecember 4, 2025 12:59
@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

This PR adds a "Manage License" button to the About page's Enterprise License Details section. The button navigates users to the license management page after verifying they have access to the meta organization.

Key Changes:

  • AddednavigateToLicense() function that checks if user has access to the meta org before navigation
  • Button is positioned next to the "Enterprise License Details" title
  • Shows authorization error notification if user lacks access to meta org
  • Added localization stringmanage_license for the button label
  • ImportsuseQuasar for notification functionality

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it adds straightforward navigation functionality with proper authorization checks
  • The implementation follows existing patterns in the codebase (similar togoToLicensePage in HomeView.vue), includes authorization validation, and handles the error case gracefully. The only minor concern is the commented-out navigation code that should be removed for cleaner code maintenance.
  • No files require special attention - both changes are straightforward

Important Files Changed

File Analysis

FilenameScoreOverview
web/src/views/About.vue4/5Added "Manage License" button that navigates to license page, with authorization check for meta org access
web/src/locales/languages/en.json5/5Addedmanage_license translation string for the new button label

Sequence Diagram

sequenceDiagram    participant User    participant AboutPage    participant Store    participant Router    participant Quasar    participant LicensePage    User->>AboutPage: Click "Manage License" button    AboutPage->>Store: Get meta_org from zoConfig    AboutPage->>Store: Find meta org in organizations list        alt Meta org found        AboutPage->>Store: dispatch("setSelectedOrganization", metaOrgOption)        Store-->>AboutPage: Organization switched        AboutPage->>Router: push({ name: 'license', query: { org_identifier } })        Router-->>LicensePage: Navigate to license page    else Meta org not found        AboutPage->>Quasar: notify("You are not authorized...")        Quasar-->>User: Show error notification    end
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings |Greptile

Comment on lines +384 to +388
// router.push({
// name: 'license',
// query: { org_identifier: metaOrgIdentifier }
// });
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

style: Remove commented-out code for cleaner maintenance

Suggested change
// router.push({
// name: 'license',
// query: { org_identifier: metaOrgIdentifier }
// });
}
}
};
Prompt To Fix With AI
This is a comment left during a code review.Path: web/src/views/About.vueLine: 384:388Comment:**style:** Remove commented-out code for cleaner maintenance```suggestion      }    };```How can I resolve this? If you propose a fix, please make it concise.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bjp232004bjp232004bjp232004 approved these changes

+1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ BugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikhilsaikethe@bjp232004

[8]ページ先頭

©2009-2025 Movatter.jp