NotificationsYou must be signed in to change notification settings
Fork715
Star17.5k

fix: issue 9285#9477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nikhilsaikethe merged 2 commits intomainfromfix/issue-9285

Dec 4, 2025

Merged

fix: issue 9285#9477

nikhilsaikethe merged 2 commits intomainfromfix/issue-9285

Dec 4, 2025

Conversation

Copy link

Contributor

nikhilsaikethe commentedDec 4, 2025

This PR fixes the issue in#9285

nikhilsaikethe force-pushed thefix/issue-9285 branch from3900b05 to1a34f1eCompare

December 4, 2025 11:38

github-actionsbot added the ☢️ BugSomething isn't working label

Dec 4, 2025

Copy link

Contributor

github-actionsbot commentedDec 4, 2025

Failed to generate code suggestions for PR

bjp232004 approved these changes

Dec 4, 2025

View reviewed changes

Copy link

Contributor

greptile-appsbot commentedDec 4, 2025

Greptile Overview

Greptile Summary

This PR fixes issue#9285 where selecting multiple streams caused the scroll position to reset to the first selected element.

Changes:

Added a defensive check for theinputValue property on theq-select component reference before callingupdateInputValue("")
Applied the fix to bothhandleMultiStreamSelection() (line 211) andhandleSingleStreamSelect() (line 228) methods
The condition now checks:indexListSelectField && indexListSelectField.inputValue && indexListSelectField.updateInputValue

Root cause:
When theinputValue property doesn't exist on theq-select component, callingupdateInputValue() appears to trigger unwanted side effects that reset the scroll position. By adding this check, the method is only called wheninputValue is present, preventing the scroll reset behavior.

Impact:

Users can now select multiple streams without the UI jumping back to the first element
No functional changes to the stream selection logic itself
Maintains backward compatibility

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is a simple defensive check that adds an additional guard condition before calling a method. It follows a common pattern of checking property existence before invoking it, which prevents potential errors and unwanted side effects. The fix is minimal, focused, and addresses the specific issue without modifying any core logic or introducing new functionality.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
web/src/plugins/logs/IndexList.vue	5/5	Added defensive check for`inputValue` property before calling`updateInputValue()` in stream selection handlers to prevent scroll position reset when multiple streams are selected

Sequence Diagram

sequenceDiagram    participant User    participant IndexList as IndexList.vue    participant QSelect as q-select Component    participant StreamSelect as streamSelect (ref)        User->>IndexList: Select multiple streams    IndexList->>IndexList: handleMultiStreamSelection()    IndexList->>IndexList: $nextTick()        Note over IndexList: Wait for DOM update        IndexList->>StreamSelect: Get ref to streamSelect        alt inputValue exists        IndexList->>StreamSelect: Check inputValue property        StreamSelect-->>IndexList: inputValue exists        IndexList->>StreamSelect: Check updateInputValue method        StreamSelect-->>IndexList: updateInputValue exists        IndexList->>StreamSelect: updateInputValue("")        Note over StreamSelect: Clear filter input without<br/>resetting scroll position    else inputValue does not exist        Note over IndexList: Skip updateInputValue call<br/>Prevents scroll reset    end        IndexList->>IndexList: onStreamChange("")    Note over IndexList: Process stream change        User->>IndexList: Select single stream    IndexList->>IndexList: handleSingleStreamSelect(opt)    IndexList->>IndexList: Update selectedStream    IndexList->>IndexList: $nextTick()        alt inputValue exists        IndexList->>StreamSelect: Check inputValue property        StreamSelect-->>IndexList: inputValue exists        IndexList->>StreamSelect: updateInputValue("")        Note over StreamSelect: Clear filter input    else inputValue does not exist        Note over IndexList: Skip updateInputValue call    end        IndexList->>IndexList: onStreamChange("")