NotificationsYou must be signed in to change notification settings
Fork715
Star17.5k

fix: issue 9455#9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nikhilsaikethe merged 4 commits intomainfromfix/issue-9455

Dec 4, 2025

Merged

fix: issue 9455#9473

nikhilsaikethe merged 4 commits intomainfromfix/issue-9455

Dec 4, 2025

Conversation

Copy link

Contributor

nikhilsaikethe commentedDec 4, 2025

This pr fixes the issue in#9455 , stream should be selected before creating scheduled job

nikhilsaikethe force-pushed thefix/issue-9455 branch fromfc742db to2afbc14Compare

December 4, 2025 09:07

github-actionsbot added the ☢️ BugSomething isn't working label

Dec 4, 2025

Copy link

Contributor

github-actionsbot commentedDec 4, 2025

Failed to generate code suggestions for PR

bjp232004 approved these changes

Dec 4, 2025

View reviewed changes

Copy link

Contributor

greptile-appsbot commentedDec 4, 2025

Greptile Overview

Greptile Summary

This PR addresses issue#9455 by adding validation checks in the logs search bar download functionality:

Added validation inaddJobScheduler() to require stream selection before scheduling jobs
Added validation indownloadRangeData() to ensure a query exists before custom range downloads
Moved empty data validation to the beginning ofdownloadLogs() function, checking before processing rather than after conversion
Changed notification positions from "top" to "bottom" for consistency

Issues to address:

The notification changes will break an existing test inSearchBar.spec.ts that expects different message text and notification type
Code formatting has inconsistent indentation in the newdownloadRangeData() validation block

Confidence Score: 3/5

This PR adds useful validation but will break an existing test and has minor code quality issues that should be addressed before merging.
Score of 3 reflects that while the functional changes are correct and address the issue requirements, there is a breaking change to an existing test case that will cause test failures, and minor code formatting inconsistencies. The core logic is sound.
web/src/plugins/logs/SearchBar.vue needs test updates in the corresponding spec file and formatting fixes.

Important Files Changed

File Analysis

Filename	Score	Overview
web/src/plugins/logs/SearchBar.vue	3/5	Added validations for stream selection and query existence before download operations. Contains style inconsistencies (indentation) and notification color using "positive" for informational "no data" messages. Existing tests will fail due to changed notification parameters.

Sequence Diagram

sequenceDiagram    participant User    participant SearchBar    participant searchService    participant Notification        Note over User,Notification: Download Flow with New Validations        User->>SearchBar: Click Download (CSV/JSON)    SearchBar->>SearchBar: downloadLogs(data, format)    alt data is empty or null        SearchBar->>Notification: "No data found to download"        Notification-->>User: Show notification    else data exists        SearchBar->>SearchBar: Convert to CSV/JSON        SearchBar-->>User: Download file    end        User->>SearchBar: Click Custom Range Download    SearchBar->>SearchBar: downloadRangeData()    alt customDownloadQueryObj.query missing        SearchBar->>Notification: "Please run a query first"        Notification-->>User: Show notification    else query exists        SearchBar->>searchService: search(query)        searchService-->>SearchBar: results        alt results.hits.length > 0            SearchBar->>SearchBar: downloadLogs(hits, format)        else no hits            SearchBar->>Notification: "No data found to download"        end    end        User->>SearchBar: Schedule Job    SearchBar->>SearchBar: addJobScheduler()    alt no stream selected        SearchBar->>Notification: "Please select a stream"        Notification-->>User: Show notification    else stream selected        SearchBar->>SearchBar: proceed with scheduling    end