Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: added saved view cleanup to cleanup spec file#9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Shrinath-O2 merged 20 commits intomainfrome2e-fixSavedViewTests
Dec 3, 2025

Conversation

@Shrinath-O2
Copy link
Contributor

No description provided.

greptile-apps[bot] reacted with thumbs up emoji
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

This PR adds saved view cleanup functionality to the test cleanup process. The implementation adds three new methods toapiCleanup.js that fetch, filter, and delete saved views matching test patterns (streamslog* andmultistream_view_*), and integrates this cleanup into the pre-test cleanup sequence incleanup.spec.js.

Key changes:

  • AddedfetchSavedViews() to retrieve all saved views via GET API
  • AddeddeleteSavedView(viewId) to delete individual saved views via DELETE API
  • AddedcleanupSavedViews() to orchestrate the cleanup process with pattern matching and logging
  • Integrated the cleanup call into the existing cleanup test sequence

The implementation follows the established patterns in the codebase for cleanup methods, includes proper error handling, uses the logging framework consistently, and matches the test data patterns found in the codebase.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The implementation is straightforward, follows existing patterns in the codebase, includes proper error handling, and only adds cleanup functionality for test data without modifying any production code or existing test logic
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
tests/ui-testing/pages/apiCleanup.js5/5Added three new methods (fetchSavedViews,deleteSavedView,cleanupSavedViews) for cleaning up test saved views matching patterns "streamslog" and "multistream_view_" - implementation is consistent with existing cleanup patterns
tests/ui-testing/playwright-tests/cleanup.spec.js5/5Added call tocleanupSavedViews() in the pre-test cleanup sequence to remove test saved views

Sequence Diagram

sequenceDiagram    participant Test as cleanup.spec.js    participant PM as PageManager    participant API as APICleanup    participant Server as OpenObserve API        Test->>PM: pm.apiCleanup.cleanupSavedViews()    PM->>API: cleanupSavedViews()        API->>API: Log "Starting saved views cleanup"        API->>Server: GET /api/{org}/savedviews    Server-->>API: Return {views: [...]}    API->>API: Log "Fetched saved views"        API->>API: Filter views matching patterns:<br/>"streamslog*" or "multistream_view_*"    API->>API: Log "Found saved views matching cleanup patterns"        alt No matching views        API->>API: Log "No saved views to clean up"        API-->>Test: Return    else Has matching views        loop For each matching view            API->>Server: DELETE /api/{org}/savedviews/{view_id}            Server-->>API: Return deletion result            alt Deletion successful (200)                API->>API: deletedCount++                API->>API: Log "Deleted saved view"            else Deletion failed                API->>API: failedCount++                API->>API: Log "Failed to delete saved view"            end        end                API->>API: Log "Saved views cleanup completed"<br/>(total, deleted, failed counts)        API-->>Test: Return    end
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings |Greptile

@Shrinath-O2Shrinath-O2 merged commit7c3ed15 intomainDec 3, 2025
51 of 54 checks passed
@Shrinath-O2Shrinath-O2 deleted the e2e-fixSavedViewTests branchDecember 3, 2025 15:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@neha00290neha00290neha00290 approved these changes

+1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

v0.30.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Shrinath-O2@neha00290

[8]ページ先頭

©2009-2025 Movatter.jp