- Notifications
You must be signed in to change notification settings - Fork715
chore:move-service-graph-config#9370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryMigrated service graph configuration from main config module to enterprise config module. The
This change correctly consolidates enterprise-feature configuration under the enterprise module, improving code organization and maintaining feature flag separation. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram participant App as Application participant MainConfig as config::get_config() participant EntConfig as o2_enterprise::...::get_config() participant ServiceGraph as Service Graph Module Note over App,ServiceGraph: Before PR (Old Pattern) App->>MainConfig: Check cfg.service_graph.enabled MainConfig-->>App: Returns bool App->>ServiceGraph: Initialize if enabled Note over App,ServiceGraph: After PR (New Pattern) App->>EntConfig: Check .service_graph.enabled EntConfig-->>App: Returns bool App->>ServiceGraph: Initialize if enabled Note over MainConfig,EntConfig: Config Migration Note over MainConfig: ServiceGraph struct removed Note over EntConfig: ServiceGraph config now here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
4 files reviewed, no comments
ad52b1a tof76cd4fComparef76cd4f to65a416dComparee0aef96 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.