Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore:move-service-graph-config#9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oasisk merged 2 commits intomainfromchore-move-service-graph-config
Nov 28, 2025
Merged

Conversation

@oasisk
Copy link
Contributor

No description provided.

greptile-apps[bot] reacted with thumbs up emoji
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

Greptile Overview

Greptile Summary

Migrated service graph configuration from main config module to enterprise config module. TheServiceGraph struct (33 lines) was removed fromsrc/config/src/config.rs, and all references were updated to useo2_enterprise::enterprise::common::config::get_config().service_graph instead ofcfg.service_graph.

  • RemovedServiceGraph struct and field from mainConfig inconfig.rs
  • Updated service graph initialization check inmain.rs
  • Updated trace ingestion service graph check inservice/traces/mod.rs
  • Updated API stats endpoint to use enterprise config inservice/traces/service_graph/api.rs

This change correctly consolidates enterprise-feature configuration under the enterprise module, improving code organization and maintaining feature flag separation.

Confidence Score: 5/5

  • This PR is safe to merge - straightforward refactoring with consistent patterns
  • Clean config migration with no logic changes - all service graph config references consistently moved from main config to enterprise config module, following the existing pattern used by other enterprise features
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
src/config/src/config.rs5/5RemovedServiceGraph config struct and field from mainConfig struct - clean removal with no issues
src/main.rs5/5Updated service graph initialization to use enterprise config instead of main config - correct enterprise pattern
src/service/traces/mod.rs5/5Updated service graph check to use enterprise config - consistent with other enterprise features
src/service/traces/service_graph/api.rs5/5Updated stats endpoint to use enterprise config forenabled field - maintains API consistency

Sequence Diagram

sequenceDiagram    participant App as Application    participant MainConfig as config::get_config()    participant EntConfig as o2_enterprise::...::get_config()    participant ServiceGraph as Service Graph Module    Note over App,ServiceGraph: Before PR (Old Pattern)    App->>MainConfig: Check cfg.service_graph.enabled    MainConfig-->>App: Returns bool    App->>ServiceGraph: Initialize if enabled    Note over App,ServiceGraph: After PR (New Pattern)    App->>EntConfig: Check .service_graph.enabled    EntConfig-->>App: Returns bool    App->>ServiceGraph: Initialize if enabled        Note over MainConfig,EntConfig: Config Migration    Note over MainConfig: ServiceGraph struct removed    Note over EntConfig: ServiceGraph config now here
Loading

Copy link
Contributor

@greptile-appsgreptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings |Greptile

@oasiskoasiskforce-pushed thechore-move-service-graph-config branch 3 times, most recently fromad52b1a tof76cd4fCompareNovember 28, 2025 13:04
@oasiskoasiskforce-pushed thechore-move-service-graph-config branch fromf76cd4f to65a416dCompareNovember 28, 2025 14:38
@oasiskoasisk merged commite0aef96 intomainNov 28, 2025
37 checks passed
@oasiskoasisk deleted the chore-move-service-graph-config branchNovember 28, 2025 16:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ByteBakerByteBakerByteBaker approved these changes

+1 more reviewer

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oasisk@ByteBaker

[8]ページ先頭

©2009-2025 Movatter.jp