- Notifications
You must be signed in to change notification settings - Fork715
fix: 8928 UI revamp issues#8940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…out in AddToDashboard
…e/openobserve into 8928-ui-revamp-issues
Closed
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment methodhere.
Contributor
Failed to generate code suggestions for PR |
68b6157 toccbd1feComparenikhilsaikethe approved these changesNov 3, 2025
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 376 | 346 | 5 | 21 | 4 | 92% | 5m 48s |
Test Failure Analysis
- serviceAccount.spec.js: All tests fail due to timeout errors waiting for a button click
- Service Account for API access Service Account Created and refresh token: Timeout waiting for button with text 'close'.
- Service Account for API access Service Account Created and updated details: Timeout waiting for button with text 'close'.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Timeout waiting for button with text 'close'.
Root Cause Analysis
- The changes iniamPage.js may have affected the visibility or availability of the 'close' button.
Recommended Actions
- Investigate the rendering logic of the 'close' button iniamPage.js to ensure it is present when expected.
- Increase the timeout duration in the clickServiceAccountPopUpClosed method to accommodate slow rendering.
- Add explicit waits or checks to confirm the button's visibility before attempting to click it.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 376 | 346 | 5 | 21 | 4 | 92% | 5m 49s |
Test Failure Analysis
- serviceAccount.spec.js: All tests fail due to timeout errors on button clicks
- Service Account for API access Service Account Created and refresh token: Locator timeout waiting for 'close' button click.
- Service Account for API access Service Account Created and updated details: Locator timeout waiting for 'close' button click.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Locator timeout waiting for 'close' button click.
Root Cause Analysis
- The failures are likely due to the locator for the 'close' button not being available or visible in the UI, as indicated by the timeout errors in the tests.
Recommended Actions
- Investigate the visibility and availability of the 'close' button iniamPage.js to ensure it is present before attempting to click. 2. Increase the timeout duration in the clickServiceAccountPopUpClosed method if the UI is slow to respond. 3. Add explicit waits or checks to confirm the button is ready for interaction before clicking.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 290 | 264 | 5 | 19 | 2 | 91% | 3m 23s |
Test Failure Analysis
- serviceAccount.spec.js: All tests fail due to strict mode violation with element locators
- Service Account for API access Service Account Created and refresh token: Locator resolved to multiple elements, causing click failure.
- Service Account for API access Service Account Created and updated details: Similar issue with multiple elements for 'cancel' button click.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Same locator issue with multiple elements preventing action.
Root Cause Analysis
- The failures are likely due to changes in the element structure or attributes in the UI, affecting the locator's ability to identify unique elements.
Recommended Actions
- Update the locator in the clickServiceAccountPopUpClosed method in iamPage.js to ensure it targets a unique element. 2. Consider adding more specific filters or using unique attributes to differentiate the buttons in the tests. 3. Review recent changes in the UI components to confirm if the button structure has changed, which may require test adjustments.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 363 | 335 | 5 | 21 | 2 | 92% | 4m 32s |
Test Failure Analysis
- serviceAccount.spec.js: Element not found errors due to multiple matching elements
- Service Account for API access Service Account Created and refresh token: Locator resolved to 2 elements, causing click failure.
- Service Account for API access Service Account Created and updated details: Same issue with multiple elements found for 'cancel'.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Click failed due to multiple elements matching 'cancel'.
Root Cause Analysis
- The failures are linked to the code change in iamPage.js where the locator was modified to filter for 'cancel', leading to multiple matches.
Recommended Actions
- Modify the locator in iamPage.js to be more specific, e.g., use a unique identifier like data-test attribute.
- Review the button elements in the UI to ensure only one matches the 'cancel' text.
- Implement additional checks in the test to confirm the visibility of the intended button before clicking.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 376 | 347 | 5 | 21 | 3 | 92% | 4m 32s |
Test Failure Analysis
- serviceAccount.spec.js: All tests fail due to strict mode violations from ambiguous button locators
- Service Account for API access Service Account Created and refresh token: Locator resolved to multiple elements for 'cancel' button.
- Service Account for API access Service Account Created and updated details: Same issue with ambiguous 'cancel' button locator.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Again, locator resolves to multiple 'cancel' buttons.
Root Cause Analysis
- The change in
iamPage.jsto filter buttons by 'cancel' caused ambiguity due to multiple matching elements.
Recommended Actions
- Update the locator in
iamPage.jsto be more specific, e.g., usedata-testattributes for unique identification. - Implement a check to ensure only one 'cancel' button is present before attempting to click.
- Review the UI to ensure that only one 'cancel' button is rendered in the relevant context.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 376 | 348 | 5 | 21 | 2 | 93% | 4m 32s |
Test Failure Analysis
- serviceAccount.spec.js: All tests fail due to strict mode violations from ambiguous button locators
- Service Account for API access Service Account Created and refresh token: Locator resolved to multiple elements for 'cancel' button.
- Service Account for API access Service Account Created and updated details: Same issue with ambiguous 'cancel' button locator.
- Service Account for API access Service Account Created and not deleted if cancel clicked: Again, multiple elements found for 'cancel' button.
Root Cause Analysis
- The code change in iamPage.js altered the button locator from 'close' to 'cancel', causing conflicts with multiple elements matching the criteria.
Recommended Actions
- Update the locator in iamPage.js to be more specific, e.g., use data-test attributes. 2. Ensure that the button with text 'cancel' is unique on the page to avoid strict mode violations. 3. Review the UI to confirm that only one 'cancel' button exists in the relevant context.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 351 | 0 | 21 | 4 | 93% | 4m 32s |
348ec69 intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.