- Notifications
You must be signed in to change notification settings - Fork715
chore(deps): bump actions/setup-node from 4 to 5#8797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Greptile Overview
Summary
This PR upgradesactions/setup-node from v4 to v5 across three instances in the Playwright workflow file.
Key Changes:
- Updates
actions/setup-nodefrom v4 to v5 on lines 77, 237, and 349 - No configuration changes to the action parameters
- Maintains existing node-version specifications (22 for build/test jobs, 20 for upload job)
Version 5 Breaking Changes (none affecting this repository):
- Automatic caching: v5 introduces automatic dependency caching when a
packageManagerfield exists inpackage.json. Since neither/web/package.jsonnor/tests/ui-testing/package.jsoncontains apackageManagerfield, this feature will not activate and behavior remains unchanged. - Node 24 runtime: The action now uses Node 24 internally. This requires GitHub Actions runner v2.327.1 or later, which should already be available on GitHub-hosted runners and self-hosted runners using labels like
repo-openobserve-standard-8andrepo-openobserve-standard-16.
Impact Assessment:
- No functional changes to the workflow behavior
- No risk of unexpected automatic caching since
packageManagerfield is not present - Standard dependency version bump with security and bug fixes included
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- This is a straightforward dependency version bump with no configuration changes. The breaking changes in v5 (automatic caching and Node 24 runtime) do not affect this repository since no
packageManagerfields are defined in package.json files. The workflow maintains all existing node-version specifications and job configurations. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/playwright.yml | 5/5 | Updatesactions/setup-node from v4 to v5 in three places (lines 77, 237, 349); changes are straightforward version bumps with no configuration modifications |
Sequence Diagram
sequenceDiagram participant GHA as GitHub Actions Runner participant Checkout as actions/checkout@v5 participant SetupNode as actions/setup-node@v5 participant NPM as npm/npx participant Playwright as Playwright Tests Note over GHA,Playwright: build_binary job GHA->>Checkout: Clone repository Checkout-->>GHA: Repository cloned GHA->>SetupNode: Setup Node.js 22 SetupNode->>SetupNode: Check for packageManager in package.json Note over SetupNode: No packageManager field found<br/>Automatic caching disabled SetupNode-->>GHA: Node.js 22 ready GHA->>NPM: cd web && npm install && npm run build NPM-->>GHA: Frontend built Note over GHA,Playwright: ui_integration_tests job GHA->>Checkout: Clone repository Checkout-->>GHA: Repository cloned GHA->>SetupNode: Setup Node.js 22 SetupNode->>SetupNode: Check for packageManager in package.json Note over SetupNode: No packageManager field found<br/>Automatic caching disabled SetupNode-->>GHA: Node.js 22 ready GHA->>NPM: cd tests/ui-testing && npm ci NPM-->>GHA: Dependencies installed GHA->>Playwright: npx playwright test Playwright-->>GHA: Tests completed Note over GHA,NPM: upload_to_testdino job GHA->>Checkout: Clone repository Checkout-->>GHA: Repository cloned GHA->>SetupNode: Setup Node.js 20 SetupNode->>SetupNode: Check for packageManager in package.json Note over SetupNode: No packageManager field found<br/>Automatic caching disabled SetupNode-->>GHA: Node.js 20 ready GHA->>NPM: npx tdpw upload NPM-->>GHA: Results uploaded1 file reviewed, no comments
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](actions/setup-node@v4...v5)---updated-dependencies:- dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
cd34917 to09bf358CompareContributorAuthor
A newer version of actions/setup-node exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
e15357f intomain 8 checks passed
Uh oh!
There was an error while loading.Please reload this page.
uddhavdave pushed a commit that referenced this pull requestOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Bumpsactions/setup-node from 4 to 5.
Release notes
Sourced fromactions/setup-node's releases.
... (truncated)
Commits
a0853c2Bump actions/checkout from 4 to 5 (#1345)b7234ccUpgrade action to use node24 (#1325)d7a1131Enhance caching in setup-node with automatic package manager detection (#1348)5e2628cBumps form-data (#1332)65becefBump undici from 5.28.5 to 5.29.0 (#1295)7e24a65Bump uuid from 9.0.1 to 11.1.0 (#1273)08f58d1Bump@octokit/request-errorand@actions/github(#1227)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)