NotificationsYou must be signed in to change notification settings
Fork715
Star17.5k

fix: No data found was displayed after refreshing on logs page till logs are fetched#8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

omkarK06 merged 2 commits intomainfromfix/logs-ui-no-data-found-on-refresh-main

Oct 31, 2025

Merged

fix: No data found was displayed after refreshing on logs page till logs are fetched#8678

omkarK06 merged 2 commits intomainfromfix/logs-ui-no-data-found-on-refresh-main

Oct 31, 2025

Conversation

Copy link

Contributor

omkarK06 commentedSep 29, 2025•
edited by github-actionsbot
Loading

PR Type

Bug fix, Enhancement

Description

Prevent "No data" flash on refresh
Set loading true before logs fetch
Minor formatting for icon attributes
Normalize SQL mode checks spacing

Diagram Walkthrough

flowchart LR  Refresh["Logs tab refresh"] -- "set loading=true" --> Loading["Loading state"]  Loading -- "loadLogsData()" --> Fetch["Fetch logs"]  Fetch -- "results" --> UI["Render logs UI"]  UI -- "no flash of 'No data'" --> UX["Improved UX"]

File Walkthrough

Relevant files

Bug fix

Index.vue `Set loading before fetching logs; minor formatting` web/src/plugins/logs/Index.vue Set`searchObj.loading = true` before`loadLogsData()` on logs tab. Adjust icon tag formatting and line breaks. Reformat SQL utils import over multiple lines. Whitespace and spacing fixes in SQL mode checks.	+17/-9

github-actionsbot added ☢️ Bug

Something isn't working

Review effort 2/5 labels

Sep 29, 2025

Copy link

Contributor

github-actionsbot commentedSep 29, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Loading State Loading is set to true before loadLogsData only when logs tab is active; ensure corresponding paths reliably set it back to false on both success and failure (including early returns or thrown errors) to avoid a stuck loading spinner. restoreUrlQueryParams(dashboardPanelData);if (isEnterpriseClusterEnabled()) { await getRegionInfo();}if (isLogsTab()) { searchObj.loading = true; loadLogsData();} else { loadVisualizeData(); UI Consistency The q-icon attributes are split across lines; verify linter/prettier settings and ensure no unintended whitespace/text-node changes or layout shifts, especially within inline headings. > <h5> <q-icon name="warning" color="warning"size="10rem" /><br /> <div SQL Mode Logic The conditional for sqlMode was reformatted; confirm behavior is unchanged and that buildSearch is not called when sqlMode is true, and that logsPageQuery handles empty strings safely before isSimpleSelectAllQuery. const handleRunQueryFn = async () => { if (searchObj.meta.logsVisualizeToggle == "visualize") { // wait to extract fields if its ongoing; if promise rejects due to abort just return silently try { let logsPageQuery = ""; // handle sql mode if (!searchObj.meta.sqlMode) { const queryBuild = buildSearch(); logsPageQuery = queryBuild?.query?.sql ?? ""; } else { logsPageQuery = searchObj.data.query; } // Check if query is SELECT * which is not supported for visualization if ( store.state.zoConfig.quick_mode_enabled === true && isSimpleSelectAllQuery(logsPageQuery)

Copy link

Contributor

github-actionsbot commentedSep 29, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Ensure loading flag resets Ensure`searchObj.loading` is reset when`loadLogsData()` completes or fails; currently it may remain true if an error occurs. Wrap the async call and always clear the loading flag in a finally block to prevent the UI from getting stuck in a loading state. web/src/plugins/logs/Index.vue [929-934] if (isLogsTab()) { searchObj.loading = true;- loadLogsData();+ try {+ await loadLogsData();+ } finally {+ searchObj.loading = false;+ } } else {- loadVisualizeData();+ await loadVisualizeData(); searchObj.loading = false;+} Suggestion importance[1-10]: 7 __ Why: Correctly identifies a potential stuck loading state and proposes using await/try/finally to reliably reset`searchObj.loading`; impact is practical but not critical.	Medium
General	Normalize query before validation Trim the reconstructed`logsPageQuery` to avoid false positives/negatives when checking for "SELECT". Whitespace or trailing semicolons can bypass `isSimpleSelectAllQuery`, leading to unsupported queries reaching visualization. web/src/plugins/logs/Index.vue [1833-1849] if (searchObj.meta.logsVisualizeToggle == "visualize") { // wait to extract fields if its ongoing; if promise rejects due to abort just return silently try { let logsPageQuery = "";- // handle sql mode if (!searchObj.meta.sqlMode) { const queryBuild = buildSearch(); logsPageQuery = queryBuild?.query?.sql ?? ""; } else { logsPageQuery = searchObj.data.query; }-+ logsPageQuery = (logsPageQuery \|\| "").trim(); // Check if query is SELECT which is not supported for visualization if ( store.state.zoConfig.quick_mode_enabled === true && isSimpleSelectAllQuery(logsPageQuery) Suggestion importance[1-10]: 5 __ Why: Trimming`logsPageQuery` before`isSimpleSelectAllQuery` can reduce edge-case mismatches, but importance is moderate and depends on`isSimpleSelectAllQuery` internals.	Low

greptile-appsbot reviewed

Sep 29, 2025

View reviewed changes

Copy link

Contributor

greptile-appsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Greptile Overview

Summary

This PR fixes a UX issue where users briefly saw "No data found" messages when refreshing the logs page before the actual data was loaded. The fix properly sets the loading state (searchObj.loading = true) before callingloadLogsData() in thesetupLogsTab() function.

Key Changes:

AddedsearchObj.loading = true; beforeloadLogsData() call insetupLogsTab() function
Fixed the loading state management to prevent premature display of empty state messages
Minor code formatting improvements forq-icon elements and import statements

Impact:

Improved user experience by showing proper loading indicators during page refresh
Consistent with existing loading state patterns used throughout the component
No breaking changes or functional alterations to core logging functionality

Confidence Score: 4/5

This PR is safe to merge with minimal risk as it only adds proper loading state management
Score reflects a straightforward UX improvement with minimal code changes. The fix follows existing patterns in the codebase and addresses a specific UI issue without introducing complexity or breaking changes
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
web/src/plugins/logs/Index.vue	4/5	Fixed loading state issue where "No data found" was briefly shown during page refresh by setting searchObj.loading = true before calling loadLogsData()

Sequence Diagram

sequenceDiagram    participant User    participant LogsPage as Logs Page Component    participant LoadLogsData as loadLogsData Function    participant API as Backend API    User->>LogsPage: Refreshes logs page    LogsPage->>LogsPage: setupLogsTab() called    Note over LogsPage: Before fix: loading state not set<br/>After fix: searchObj.loading = true    LogsPage->>LoadLogsData: loadLogsData()    LoadLogsData->>API: getStreamList()    LoadLogsData->>API: getFunctions()    LoadLogsData->>API: extractFields()    LoadLogsData->>API: getQueryData()    API-->>LoadLogsData: Return data    LoadLogsData->>LogsPage: refreshData()    Note over LogsPage: searchObj.loading = false<br/>Data displayed to user    LogsPage-->>User: Show logs data

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings |Greptile}

omkarK06 force-pushed thefix/logs-ui-no-data-found-on-refresh-main branch 2 times, most recently from3bcd8d3 to5e879f1Compare

October 3, 2025 11:01

bjp232004 approved these changes

Oct 3, 2025

View reviewed changes

omkarK06 added2 commits

October 31, 2025 17:03

fix: No data found was displayed after refreshing on logs page till l…

1f487c8

…ogs are fetched

fix: When a logs short URL is created and opened, trying to add a col…

9352545

…umn to the table using the eye icon does not add the column

omkarK06 force-pushed thefix/logs-ui-no-data-found-on-refresh-main branch from5e879f1 to9352545Compare

October 31, 2025 11:33

Copy link

testdino-playwright-reporterbot commentedOct 31, 2025

⚠️ Test Run Unstable

Author:`omkarK06` | Branch:`fix/logs-ui-no-data-found-on-refresh-main` | Commit:`9352545`

Testdino Test Results

Status	Total	Passed	Failed	Skipped	Flaky	Pass Rate	Duration
All tests passed	376	349	0	21	6	93%	5m 31s

View Detailed Results

omkarK06 merged commit1d4a796 intomain

Oct 31, 2025

33 checks passed

omkarK06 deleted the fix/logs-ui-no-data-found-on-refresh-main branch

October 31, 2025 13:22

Labels

☢️ Bug

Something isn't working

Review effort 2/5

Movatterモバイル変換

fix: No data found was displayed after refreshing on logs page till logs are fetched#8678

fix: No data found was displayed after refreshing on logs page till logs are fetched#8678

Uh oh!

Conversation

omkarK06 commentedSep 29, 2025• edited by github-actionsbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

github-actionsbot commentedSep 29, 2025

PR Reviewer Guide 🔍

Uh oh!

github-actionsbot commentedSep 29, 2025

PR Code Suggestions ✨

Uh oh!

greptile-appsbot left a comment

Choose a reason for hiding this comment

Greptile Overview

Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

testdino-playwright-reporterbot commentedOct 31, 2025

⚠️ Test Run Unstable

Author:omkarK06 | Branch:fix/logs-ui-no-data-found-on-refresh-main | Commit:9352545

Testdino Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

omkarK06 commentedSep 29, 2025•
edited by github-actionsbot
Loading

Author:`omkarK06` | Branch:`fix/logs-ui-no-data-found-on-refresh-main` | Commit:`9352545`