Greptile Summary

This PR fixes a configuration logic bug in the cache latest files system by adding missing checks for the masterenabled flag across three critical files. The OpenObserve codebase has a hierarchical caching configuration system wherecache_latest_files.enabled serves as the master switch that should gate all caching operations, with specific sub-flags likecache_parquet,cache_index, anddownload_from_node controlling individual caching behaviors.

The affected files were inconsistently checking the configuration flags:

• src/job/files/parquet.rs: Missingenabled check in the ingester's parquet file caching logic
• src/service/compact/merge.rs: Missingenabled check in two locations within the compactor's merge operations
• src/service/tantivy/mod.rs: Missingenabled check in the Tantivy search index caching logic

The fix ensures that all three components now follow the same pattern: first check ifcache_latest_files.enabled is true, then verify the specific feature flags (cache_parquet orcache_index), and finally confirmdownload_from_node is enabled. This creates consistent behavior where settingZO_CACHE_LATEST_FILES_ENABLED=false will properly disable all local file caching operations across the ingester, compactor, and search indexing components.

Additionally, the Tantivy module change includes a minor optimization by caching the config reference in a local variable instead of callingget_config() multiple times.

Confidence score: 5/5

• This PR is safe to merge with minimal risk as it only adds missing configuration checks without changing core logic
• Score reflects simple, consistent changes that fix a clear configuration bug with no breaking changes to existing functionality
• No files require special attention as all changes follow the same straightforward pattern

_{3 files reviewed, no comments}

_{Edit Code Review Bot Settings |Greptile}