opennextjs/opennextjs-netlifyPublic

NotificationsYou must be signed in to change notification settings
Fork96
Star796

test: add locale assertions for middleware handling#2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

pieh wants to merge2 commits intomain

base:main

Choose a base branch

frommichalpiechowiak/frb-1919-version-5113-doesnt-seem-to-pass-the-correct-locale-anymore

Draft

test: add locale assertions for middleware handling#2984

pieh wants to merge2 commits intomainfrommichalpiechowiak/frb-1919-version-5113-doesnt-seem-to-pass-the-correct-locale-anymore

Conversation

Copy link

Contributor

Description

Tests

You can test this change yourself like so:

TODO

Relevant links (GitHub issues, etc.) or a picture of cute animal

#2973
https://linear.app/netlify/issue/FRB-1919/version-5113-doesnt-seem-to-pass-the-correct-locale-anymore-from

test: add locale assertions for middleware handling

f0d47c1

Copy link

Contributor

github-actionsbot commentedJun 27, 2025•
edited
Loading

📊 Package size report `No changes`

File	Before (Size / Gzip)	After (Size / Gzip)
Total_{(Includes all files)}	`2.9 MB` /`815.5 kB`	`2.9 MB` /`815.5 kB`
Tarball size	`772.8 kB`	^0%↑`772.9 kB`

Unchanged files

File	Size (Size / Gzip)
`dist/build/advanced-api-routes.js`	`4.3 kB` /`1.4 kB`
`dist/build/cache.js`	`1.0 kB` /`416 B`
`dist/build/content/next-shims/telemetry-storage.cjs`	`1.6 kB` /`659 B`
`dist/build/content/prerendered.js`	`9.9 kB` /`2.9 kB`
`dist/build/content/server.js`	`9.9 kB` /`3.3 kB`
`dist/build/content/static.js`	`4.2 kB` /`1.4 kB`
`dist/build/functions/edge.js`	`20.9 kB` /`5.6 kB`
`dist/build/functions/server.js`	`4.9 kB` /`1.6 kB`
`dist/build/image-cdn.js`	`54.0 kB` /`11.1 kB`
`dist/build/plugin-context.js`	`11.3 kB` /`3.3 kB`
`dist/build/templates/handler-monorepo.tmpl.js`	`1.6 kB` /`643 B`
`dist/build/templates/handler.tmpl.js`	`1.4 kB` /`596 B`
`dist/build/verification.js`	`4.5 kB` /`1.6 kB`
`dist/esm-chunks/chunk-6BT4RYQJ.js`	`1.9 kB` /`862 B`
`dist/esm-chunks/chunk-FKDTZJRV.js`	`27.0 kB` /`5.4 kB`
`dist/esm-chunks/chunk-TLQCAGE2.js`	`62.6 kB` /`11.2 kB`
`dist/esm-chunks/chunk-YUXQHOYO.js`	`187.9 kB` /`33.2 kB`
`dist/index.js`	`3.4 kB` /`1.1 kB`
`dist/run/config.js`	`1.3 kB` /`649 B`
`dist/run/constants.js`	`526 B` /`319 B`
`dist/run/handlers/cache.cjs`	`15.6 kB` /`3.8 kB`
`dist/run/handlers/request-context.cjs`	`5.3 kB` /`1.7 kB`
`dist/run/handlers/server.js`	`142.6 kB` /`33.5 kB`
`dist/run/handlers/tags-handler.cjs`	`7.2 kB` /`2.4 kB`
`dist/run/handlers/tracer.cjs`	`30.2 kB` /`6.3 kB`
`dist/run/handlers/use-cache-handler.js`	`48.0 kB` /`10.8 kB`
`dist/run/handlers/wait-until.cjs`	`1.4 kB` /`665 B`
`dist/run/headers.js`	`8.2 kB` /`2.6 kB`
`dist/run/next.cjs`	`23.9 kB` /`5.9 kB`
`dist/run/revalidate.js`	`1.0 kB` /`479 B`
`dist/run/storage/regional-blob-store.cjs`	`21.3 kB` /`6.1 kB`
`dist/run/storage/request-scoped-in-memory-cache.cjs`	`47.4 kB` /`10.9 kB`
`dist/run/storage/storage.cjs`	`4.0 kB` /`1.3 kB`
`dist/shared/blob-types.cjs`	`1.6 kB` /`645 B`
`dist/shared/blobkey.js`	`742 B` /`400 B`
`dist/shared/cache-types.cjs`	`1.3 kB` /`566 B`
`edge-runtime/lib/headers.ts`	`1.9 kB` /`841 B`
`edge-runtime/lib/logging.ts`	`115 B` /`121 B`
`edge-runtime/lib/middleware.test.ts`	`3.3 kB` /`645 B`
`edge-runtime/lib/middleware.ts`	`3.6 kB` /`1.4 kB`
`edge-runtime/lib/next-request.ts`	`3.3 kB` /`1.1 kB`
`edge-runtime/lib/response.ts`	`10.0 kB` /`3.0 kB`
`edge-runtime/lib/routing.ts`	`15.3 kB` /`4.0 kB`
`edge-runtime/lib/util.test.ts`	`1.6 kB` /`356 B`
`edge-runtime/lib/util.ts`	`3.7 kB` /`1.3 kB`
`edge-runtime/matchers.json`	`3 B` /`23 B`
`edge-runtime/middleware.ts`	`2.4 kB` /`1.0 kB`
`edge-runtime/next.config.json`	`3 B` /`23 B`
`edge-runtime/README.md`	`992 B` /`509 B`
`edge-runtime/shim/index.js`	`1.5 kB` /`717 B`
`edge-runtime/vendor.ts`	`745 B` /`312 B`
`edge-runtime/vendor/deno.land/std@0.175.0/_util/asserts.ts`	`854 B` /`461 B`
`edge-runtime/vendor/deno.land/std@0.175.0/_util/os.ts`	`644 B` /`355 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/abortable.ts`	`4.0 kB` /`1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/deadline.ts`	`974 B` /`544 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/debounce.ts`	`2.2 kB` /`956 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/deferred.ts`	`1.5 kB` /`798 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/delay.ts`	`1.8 kB` /`845 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/mod.ts`	`465 B` /`241 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/mux_async_iterator.ts`	`2.5 kB` /`1.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/pool.ts`	`3.2 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/retry.ts`	`2.4 kB` /`1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/tee.ts`	`2.1 kB` /`924 B`
`edge-runtime/vendor/deno.land/std@0.175.0/bytes/index_of_needle.ts`	`1.4 kB` /`668 B`
`edge-runtime/vendor/deno.land/std@0.175.0/crypto/timing_safe_equal.ts`	`875 B` /`442 B`
`edge-runtime/vendor/deno.land/std@0.175.0/datetime/to_imf.ts`	`1.3 kB` /`681 B`
`edge-runtime/vendor/deno.land/std@0.175.0/encoding/base64.ts`	`2.5 kB` /`1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/encoding/base64url.ts`	`2.0 kB` /`872 B`
`edge-runtime/vendor/deno.land/std@0.175.0/flags/mod.ts`	`22.6 kB` /`5.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/fmt/colors.ts`	`12.4 kB` /`2.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/fmt/printf.ts`	`27.7 kB` /`7.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/http/cookie.ts`	`11.5 kB` /`3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_core.ts`	`2.3 kB` /`716 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_events.d.ts`	`27.2 kB` /`5.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_events.mjs`	`28.0 kB` /`7.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_global.d.ts`	`1.7 kB` /`650 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_next_tick.ts`	`5.0 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/exiting.ts`	`138 B` /`138 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/process.ts`	`3.8 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/stdio.mjs`	`336 B` /`233 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/streams.mjs`	`4.0 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_stream.d.ts`	`53.2 kB` /`11.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_stream.mjs`	`91.2 kB` /`25.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_util/_util_callbackify.ts`	`4.3 kB` /`1.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_utils.ts`	`5.9 kB` /`2.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/assert.ts`	`23.1 kB` /`4.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/assertion_error.ts`	`19.6 kB` /`6.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/async_hooks.ts`	`7.7 kB` /`2.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/buffer.ts`	`262 B` /`204 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/events.ts`	`303 B` /`221 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_libuv_winerror.ts`	`7.8 kB` /`1.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_listen.ts`	`561 B` /`342 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_node.ts`	`443 B` /`335 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_timingSafeEqual.ts`	`479 B` /`268 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_utils.ts`	`2.4 kB` /`938 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_winerror.ts`	`354.4 kB` /`64.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/ares.ts`	`2.4 kB` /`1.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/async_wrap.ts`	`4.0 kB` /`1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/buffer.ts`	`3.5 kB` /`1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/cares_wrap.ts`	`15.2 kB` /`3.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/config.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/connection_wrap.ts`	`2.6 kB` /`1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/constants.ts`	`21.5 kB` /`5.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/contextify.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/credentials.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/crypto.ts`	`448 B` /`244 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/errors.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs_dir.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs_event_wrap.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/handle_wrap.ts`	`1.8 kB` /`1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/heap_utils.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/http_parser.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/icu.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/inspector.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/js_stream.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/messaging.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/mod.ts`	`3.1 kB` /`955 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/module_wrap.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/native_module.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/natives.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/node_file.ts`	`2.9 kB` /`1.5 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/node_options.ts`	`1.8 kB` /`989 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/options.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/os.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/performance.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/pipe_wrap.ts`	`10.4 kB` /`3.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/process_methods.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/report.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/serdes.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/signal_wrap.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/spawn_sync.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/stream_wrap.ts`	`9.3 kB` /`2.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/string_decoder.ts`	`504 B` /`261 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/symbols.ts`	`1.4 kB` /`828 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/task_queue.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tcp_wrap.ts`	`13.1 kB` /`3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/timers.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tls_wrap.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/trace_events.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tty_wrap.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/types.ts`	`5.7 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/udp_wrap.ts`	`12.4 kB` /`3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/url.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/util.ts`	`4.0 kB` /`1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/uv.ts`	`20.1 kB` /`3.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/v8.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/worker.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/zlib.ts`	`87 B` /`104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/buffer.d.ts`	`73.6 kB` /`12.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/buffer.mjs`	`66.1 kB` /`10.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/crypto/_keys.ts`	`463 B` /`262 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/crypto/constants.ts`	`252 B` /`173 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/error_codes.ts`	`322 B` /`250 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/errors.ts`	`78.9 kB` /`17.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/fixed_queue.ts`	`4.4 kB` /`1.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/hide_stack_frames.ts`	`550 B` /`377 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/net.ts`	`3.1 kB` /`1.5 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/normalize_encoding.mjs`	`2.1 kB` /`500 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/options.ts`	`1.7 kB` /`959 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/primordials.mjs`	`1.8 kB` /`431 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/process/per_thread.mjs`	`7.8 kB` /`2.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/readline/callbacks.mjs`	`3.8 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/readline/utils.mjs`	`14.3 kB` /`3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/destroy.mjs`	`6.9 kB` /`1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/end-of-stream.mjs`	`7.1 kB` /`1.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/utils.mjs`	`5.9 kB` /`1.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util.mjs`	`4.0 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/comparisons.ts`	`16.6 kB` /`3.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/debuglog.ts`	`3.2 kB` /`1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/inspect.mjs`	`71.5 kB` /`19.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/types.ts`	`3.7 kB` /`1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/validators.mjs`	`8.0 kB` /`2.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/process.ts`	`19.4 kB` /`5.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/stream.ts`	`671 B` /`346 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/string_decoder.ts`	`10.3 kB` /`3.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/util.ts`	`7.8 kB` /`2.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/util/types.ts`	`199 B` /`153 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_constants.ts`	`2.0 kB` /`727 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_interface.ts`	`728 B` /`369 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_util.ts`	`5.0 kB` /`1.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/common.ts`	`1.2 kB` /`607 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/glob.ts`	`12.7 kB` /`3.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/mod.ts`	`1.4 kB` /`690 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/posix.ts`	`13.9 kB` /`3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/separator.ts`	`259 B` /`209 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/win32.ts`	`28.5 kB` /`6.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/streams/write_all.ts`	`2.2 kB` /`598 B`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/_diff.ts`	`11.6 kB` /`3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/_format.ts`	`705 B` /`462 B`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/asserts.ts`	`25.5 kB` /`5.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/types.d.ts`	`4.2 kB` /`1.2 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/pkg/htmlrewriter_bg.wasm`	`573.2 kB` /`262.7 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/pkg/htmlrewriter.js`	`31.0 kB` /`4.7 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/src/index.ts`	`2.6 kB` /`989 B`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/src/types.d.ts`	`2.1 kB` /`446 B`
`edge-runtime/vendor/deno.land/x/path_to_regexp@v6.2.1/index.ts`	`15.4 kB` /`4.2 kB`
`edge-runtime/vendor/import_map.json`	`148 B` /`111 B`
`edge-runtime/vendor/v1-7-0--edge-utils.netlify.app/logger/logger.ts`	`3.2 kB` /`747 B`
`edge-runtime/vendor/v1-7-0--edge-utils.netlify.app/logger/mod.ts`	`29 B` /`49 B`
`LICENSE`	`1.1 kB` /`661 B`
`manifest.yml`	`31 B` /`51 B`
`package.json`	`3.2 kB` /`1.2 kB`
`README.md`	`2.8 kB` /`1.2 kB`

_{🤖 This report was automatically generated bypkg-size-action}

pieh mentioned this pull request

Jun 27, 2025

version 5.11.3 doesn't seem to pass the correct locale anymore from middleware.#2973

Open

test: adjust fixture to use NextUrl to preserve locale when rewriting

a623845

pieh added the test all versionsRun e2e tests against old and canary versions of Next.js label

Jun 30, 2025

pieh commented

Jun 30, 2025

View reviewed changes

tests/fixtures/middleware-i18n/middleware.js

Comment on lines -20 to +25

		constrewriteUrl=newURL(
		url.pathname.replace('/link/rewrite-me','/link/rewrite-target'),
		url,
		)
		returnNextResponse.rewrite(rewriteUrl,{
		// use NextUrl to rewrite the URL as it does preserve the locale
		url.pathname=url.pathname.replace('/link/rewrite-me','/link/rewrite-target')
		returnNextResponse.rewrite(url,{

Copy link

ContributorAuthor

piehJun 30, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note: previous rewrite was just losing locale url due to using justNextURL.pathname to construct newURL effectively losing locale context in the process.

This change keeps usingNextURL and just mutatepathname portion of it which preservelocale context and resulting in working as expected rewrites

pieh commented

Jun 30, 2025

View reviewed changes

tests/e2e/edge-middleware.test.ts

		describeLabel:'NextResponse.next() -> getServerSideProps page',
		selector:'NextResponse.next()#getServerSideProps',
		jsonPathMatcher:'/link/next-getserversideprops.json',
		assertLocale:true,

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OnlygetServerSideProps andgetStaticProps even have access to locale and "fully static page" cases just don't have access to it so asserting locale is optional check enabled to cases when locale is even available to check

Labels

test all versions

Run e2e tests against old and canary versions of Next.js

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add locale assertions for middleware handling#2984

Are you sure you want to change the base?

test: add locale assertions for middleware handling#2984

Uh oh!

Conversation

pieh commentedJun 27, 2025

Description

Tests

Relevant links (GitHub issues, etc.) or a picture of cute animal

Uh oh!

github-actionsbot commentedJun 27, 2025•
edited
Loading