- Notifications
You must be signed in to change notification settings - Fork88
feat: allow next middleware to use edge cache#2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cshawaus wants to merge1 commit intoopennextjs:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dbdf03e to4f6232bCompare4f6232b to6ebb9dcCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
type: featurecode contributing to the implementation of a feature and/or user facing functionality
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow the Next.js middleware to use Edge caching as a configurable flag.
This is a beneficial feature for the Next.js middleware, and I cannot think of any reason why the Next.js Edge Function can't support it after patching and testing it in a real project with zero side effects.
In addition, sharing code between Next.js and vanilla Edge Functions can be very tricky, while having everything under one roof with caching capability simplifies the entire process.
Documentation
https://docs.netlify.com/edge-functions/optional-configuration/#response-caching
Tests
I have included a new fixture and integration test that toggles Edge caching on.
Relevant links (GitHub issues, etc.) or a picture of cute animal
n/a