NotificationsYou must be signed in to change notification settings
Fork195
Star121

8266510: Nimbus JTree default tree cell renderer does not use selected text color#140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

akashche wants to merge1 commit intoopenjdk:masterfromakashche:8266510-backport

Closed

8266510: Nimbus JTree default tree cell renderer does not use selected text color#140

akashche wants to merge1 commit intoopenjdk:masterfromakashche:8266510-backport

Conversation

Copy link

Contributor

akashche commentedOct 1, 2021•
edited by openjdkbot
Loading

This is a clean backport of the JTree nodes text color fix, I intend to follow up with backporting JDK-8271315.

Testing: checked manually on Linux, Windows and Mac with SwingSet2 that JTree node text color is black without the patch and is correct with the patch.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8266510: Nimbus JTree default tree cell renderer does not use selected text color

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.java.net/jdk17u pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/140.diff

Backport ecd445562f8355704a041f9eca0e87dc85a7f44c

6d52d09

Copy link

bridgekeeperbot commentedOct 1, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

openjdkbot changed the title~~Backport ecd445562f8355704a041f9eca0e87dc85a7f44c~~8266510: Nimbus JTree default tree cell renderer does not use selected text color

Oct 1, 2021

Copy link

openjdkbot commentedOct 1, 2021

This backport pull request has now been updated with issue from the originalcommit.

openjdkbot added backport

Port of a pull request already in a different code base

cleanIdentical backport; no merge resolution required labels

Oct 1, 2021

Copy link

openjdkbot commentedOct 1, 2021•
edited
Loading

@akashche This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266510: Nimbus JTree default tree cell renderer does not use selected text color

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to themaster branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

As you do not haveCommitter status inthis project an existing Committer must agree tosponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type/integrate in a new comment. (Afterwards, your sponsor types/sponsor in a new comment to perform the integration).

openjdkbot added ready

Pull request is ready to be integrated

rfrPull request is ready for review labels

Oct 1, 2021

Copy link

mlbridgebot commentedOct 1, 2021

Webrevs

00:Full (6d52d09d)

Copy link

bridgekeeperbot commentedOct 29, 2021

@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link

ContributorAuthor

akashche commentedNov 1, 2021

Gentle reminder, it would be great if someone can review this backport.

Copy link

Member

phohensee commentedNov 3, 2021

Clean backports don't need review. Just tag the JBS issue.

Copy link

ContributorAuthor

akashche commentedNov 3, 2021

Marked the bug for approval.

Copy link

ContributorAuthor

akashche commentedNov 5, 2021

/integrate

Copy link

openjdkbot commentedNov 5, 2021

Going to push as commit23326d5.
Since your change was applied there have been 129 commits pushed to themaster branch:

00fed20: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows
9f3c840: 8268361: Fix the infinite loop in next_line
4003db8: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
229cb35: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java
de47488: 8270290: NTLM authentication fails if HEAD request is used
802844a: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
a0899bf: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
583844a: 8275302: unexpected compiler error: cast, intersection types and sealed
0364737: 8276122: Change openjdk project in jcheck to jdk-updates
25bfea6: 8276130: Fix Github Actions of JDK17u to account for update version scheme
... and 119 more:https://git.openjdk.java.net/jdk17u/compare/24903860dd401dcf742d750388aae09efb0e8a1e...master