Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large#49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@jerboaa
Copy link
Contributor

@jerboaajerboaa commentedAug 12, 2022•
edited by openjdkbot
Loading

PR to backout the change ofJDK-8279219. I'll change this to the proper backport title once JDK 19 backout is done.

Progress

  • Change must be properly reviewed (1 review required, with at least 1Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk11u pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/49.diff

@bridgekeeper
Copy link

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR intojdk11.0.16.1 will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot added the rfrPull request is ready for review labelAug 12, 2022
@mlbridge
Copy link

Webrevs

Copy link
Member

@tstuefetstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backout looks clean.

I also applied it and checked delta between this PR and the commit before 8279219. Affected files look identical apart from opto/split_if.cpp which was modified with as part of "8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination"22f8e21

@openjdk
Copy link

openjdkbot commentedAug 12, 2022•
edited
Loading

@jerboaa This change now passes allautomated pre-integration checks.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeReviewed-by: stuefe

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to thejdk11.0.16.1 branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to thejdk11.0.16.1 branch, type/integrate in a new comment.

@openjdkopenjdkbot added the readyPull request is ready to be integrated labelAug 12, 2022
@jerboaajerboaa changed the title8292260: Backout [REDO] C2 crash when allocating array of size too large8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeAug 12, 2022
@jerboaajerboaa changed the title8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeBackport 967a28c3d85fdde6d5eb48aa0edd8f7597772469Aug 12, 2022
@openjdkopenjdkbot changed the titleBackport 967a28c3d85fdde6d5eb48aa0edd8f75977724698292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeAug 12, 2022
@openjdk
Copy link

openjdkbot commentedAug 12, 2022

This backport pull request has now been updated with issue from the originalcommit.

@openjdkopenjdkbot added the backportPort of a pull request already in a different code base labelAug 12, 2022
@jerboaa
Copy link
ContributorAuthor

/integrate

@openjdk
Copy link

openjdkbot commentedAug 12, 2022

Going to push as commit63e4b5c.

@openjdkopenjdkbot added the integratedPull request has been integrated labelAug 12, 2022
@openjdkopenjdkbot closed thisAug 12, 2022
@openjdkopenjdkbot removed readyPull request is ready to be integrated rfrPull request is ready for review labelsAug 12, 2022
@openjdk
Copy link

openjdkbot commentedAug 12, 2022

@jerboaa Pushed as commit63e4b5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov
Copy link
Contributor

@jerboaa I don't see corresponding backport bug linked to JDK-8292260.

@RealCLanger
Copy link
Contributor

@jerboaa I don't see corresponding backport bug linked to JDK-8292260.

I believe a backport bug will be created once we merge this back into the master branch. Let's see what happens. If Skara bots fail to do so, we need to create one manually.

@jerboaa
Copy link
ContributorAuthor

jerboaa commentedAug 15, 2022•
edited
Loading

We've only integrated this into thejdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create one manually for 11.0.16.1.

@kevinrushforth
Copy link
Member

We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1.

@jerboaa I alerted@erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record.

@jerboaa
Copy link
ContributorAuthor

@kevinrushforth OK. Thank you!

@RealCLanger
Copy link
Contributor

We've only integrated this into the jdk11.0.16.1 branch and that might confuse SKARA tooling. At least I've observed that the version bump bug didn't get resolved properly by the bots too. Not sure what's going on. We'll likely have to create on manually for 11.0.16.1.

@jerboaa I alerted@erikj79 who has discovered the reason that the JBS backport record wasn't created and the commit URL wasn't added as a comment. It should be fixed shortly, so you should not have to manually create the record.

Looks like this is resolved now. Good to know that the Skara bots also operate on branches.

jerboaa reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@tstuefetstuefetstuefe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backportPort of a pull request already in a different code baseintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jerboaa@vnkozlov@RealCLanger@kevinrushforth@tstuefe
[8]ページ先頭
©2009-2025 Movatter.jp