- Notifications
You must be signed in to change notification settings - Fork836
Strip logging for non-trace errors#891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
markojovanov wants to merge1 commit intoopenid:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Strip logging for non-trace errors#891
markojovanov wants to merge1 commit intoopenid:masterfrommarkojovanov:improvement/remove-logging-in-release-configuration
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ankushkushwaha approved these changesDec 16, 2024
Christophorus3 approved these changesOct 16, 2025
Christophorus3 commentedOct 16, 2025
Can we please have some feedback on this? Or better, an approval so it can be merged and go into an upcoming release? |
ankushkushwaha commentedOct 21, 2025
Someone from the core team should review this pull request. |
ankushkushwaha approved these changesOct 26, 2025
Christophorus3 commentedOct 27, 2025
Who is part of the core team, to ping here? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OpenID Connect (OIDC) implementations, it is recommended to remove any logging from release builds for security and performance reasons. During my investigation of this project, I identified two log messages that were not covered by the newly introduced request trace mechanism, which was designed to allow logging only for debugging purposes.
This improvement aims to enhance security by ensuring that sensitive or unnecessary logs are not present in release builds.
Request:
If these log messages are intentional and have a specific purpose, please provide an explanation of why they should remain. Your feedback will help clarify their necessity.