openid/AppAuth-iOSPublic

NotificationsYou must be signed in to change notification settings
Fork836
Star1.9k

Correct nullability annotations in OIDEndSessionRequest#702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

philet wants to merge2 commits intoopenid:master

base:master

Choose a base branch

fromphilet:endsession-request-nullability

Open

Correct nullability annotations in OIDEndSessionRequest#702

philet wants to merge2 commits intoopenid:masterfromphilet:endsession-request-nullability

Conversation

Copy link

philet commentedApr 8, 2022•
edited by petea
Loading

Correct nullability annotations forOIDEndSessionRequest parametersidTokenHint,postLogoutRedirectURL, andstate.

Fixes#565

Correct nullability for OIDEndSessionRequest parameters idTokenHint, …

0d6df52

…postLogoutRedirectURL, state

philet mentioned this pull request

Apr 8, 2022

Update parameter nullability#566

Closed

Copy link

Collaborator

petea commentedApr 8, 2022

@philet have you signed thecontributor agreements?

Copy link

Author

philet commentedApr 11, 2022

@petea I have signed them last Friday. Probably still needs to be processed on your side.

Copy link

Collaborator

petea commentedAug 16, 2022

@philet confirmed that we have the needed documentation from you, thanks.

petea changed the title~~Correct nullability for OIDEndSessionRequest parameters idTokenHint, …~~Correct nullability annotations in OIDEndSessionRequest

Aug 16, 2022

Copy link

Collaborator

petea commentedAug 16, 2022

Since this will be a breaking change for the Swift interface, we'll need to make it as part of a major release.

petea added this to the2.0.0 milestone

Aug 16, 2022

Copy link

nbransby commentedNov 4, 2022

@petea since its only adding the nullability won't existing code still compile meaning its not a breaking change?

Copy link

pfei5 commentedJan 30, 2023

We're having to run a fork of this lib because of this issue. Is there anything missing from the PR that we could provide?

xeniabeckel approved these changes

Jan 30, 2023

View reviewed changes

Copy link

trykovyura commentedJun 8, 2025

Copy link

MichaelHackett commentedAug 22, 2025

@petea: Please provide an update. Is@nbransby correct about it not being a breaking change? I'd rather not have to maintain a fork of the library just to address this one issue, so I'd like to see this finally accepted and merged. It looks to me like it wasn't even changed in the 2.0.0 release, where a breaking change (if it actually is) could have been made.