This repository was archived by the owner on May 1, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork74
Upgrade edx-enterprise-data to 0.2.5 and unpin many requirements#206
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Unpinned a number of requirements so they would be upgraded as part of`make upgrade` as recommended by OEP-18. In particular the edx-enterprise-datadjango app was not pinning edx-drf-extensions which resulted in 2 differentversions of DRF in the requirements (one for enterprise-data and one for thisIDA).Upgrading DRF resulting in an assertion failure that was added in DRF 3.7.4```Cannot both declare the field 'created' and include it in the CourseProgramMetadataSerializer'exclude' option. Remove the field or, if inherited from a parent serializer, disable with `created = None`.```encode/django-rest-framework#5599Because the created date was being excluded, it is not needed in the CourseProgramMetadataSerializer andhas been removed.
Codecov Report
@@ Coverage Diff @@## master #206 +/- ##======================================= Coverage 97.85% 97.85% ======================================= Files 53 53 Lines 3173 3173 Branches 247 247 ======================================= Hits 3105 3105 Misses 43 43 Partials 25 25
Continue to review full report at Codecov.
|
adamstankiewicz approved these changesAug 29, 2018
Contributor
adamstankiewicz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
christopappas approved these changesAug 29, 2018
Contributor
christopappas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ran the tests, all pass!
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Unpinned a number of requirements so they would be upgraded as part of
make upgradeas recommended by OEP-18. In particular the edx-enterprise-datadjango app was not pinning edx-drf-extensions which resulted in 2 different
versions of DRF in the requirements (one for enterprise-data and one for this
IDA).
Upgrading DRF resulting in an assertion failure that was added in DRF 3.7.4
encode/django-rest-framework#5599
Because the created date was being excluded, it is not needed in the CourseProgramMetadataSerializer and has been removed.