- Notifications
You must be signed in to change notification settings - Fork5.9k
Fix SIGBUS crash in wechat_qrcode during process shutdown#4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
0AnshuAditya0 wants to merge7 commits intoopencv:5.xChoose a base branch
base:5.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix SIGBUS crash in wechat_qrcode during process shutdown#4039
0AnshuAditya0 wants to merge7 commits intoopencv:5.xfrom0AnshuAditya0:fix-wechat-qrcode-shutdown-crash
+54 −47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixesopencv/opencv#27971Problem:Double-free crash in std::vector<zxing::Ref<zxing::qrcode::Version>>::~vector()during process shutdown when using wechat_qrcode module. The crash occurred witherror "free(): double free detected in tcache 2" and SIGBUS signal.Root Cause:Static member variable VERSIONS was destroyed during shutdown while Ref<Version>objects still held references, causing double-free due to static initializationorder fiasco.Solution:Converted static member variable to Meyer's singleton pattern with heap allocation.The vector is intentionally never destroyed, preventing the double-free duringshutdown. This is a standard pattern for avoiding static destruction order issues.Changes:- version.hpp: Changed VERSIONS declaration to getVersions() function- version.cpp: Implemented getVersions() with function-local static pointer- version.cpp: Updated all 15+ references to use getVersions() instead of VERSIONSTesting:- Existing tests pass without crashes- No SIGBUS crash on shutdown- Small intentional memory "leak" (singleton pattern) is acceptable
asmorkalov requested changesNov 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
cc5ccb7 to2286562Compare2286562 to210d09fCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesopencv/opencv#27971
Problem:
Double-free crash in std::vector<zxing::Refzxing::qrcode::Version>::~vector()
during process shutdown when using wechat_qrcode module. The crash occurred with
error "free(): double free detected in tcache 2" and SIGBUS signal.
Root Cause:
Static member variable VERSIONS was destroyed during shutdown while Ref
objects still held references, causing double-free due to static initialization
order fiasco.
Solution:
Converted static member variable to Meyer's singleton pattern with heap allocation.
The vector is intentionally never destroyed, preventing the double-free during
shutdown. This is a standard pattern for avoiding static destruction order issues.
Changes:
Testing: