Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add to mcc detect and infer test#3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@AleksandrPanov
Copy link
Contributor

@AleksandrPanovAleksandrPanov commentedMar 3, 2024
edited
Loading

merge withopencv/opencv_extra#1153

Added a full pipeline tests:

  1. detector->process(img, (TYPECHART)0, 1, true);
  2. ColorCorrectionModel model(src, COLORCHECKER_Macbeth); model.run();
  3. calibratedImage = model.infer(calibratedImage)*255.;

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanovAleksandrPanov added test category: mcccolor calibration module labelsMar 3, 2024
@AleksandrPanovAleksandrPanovforce-pushed theadd_to_mcc_detect_and_infer_test branch fromdbc62de toe137ad6CompareMarch 3, 2024 22:08
@AleksandrPanovAleksandrPanov mentioned this pull requestMar 3, 2024
6 tasks
@AleksandrPanovAleksandrPanovforce-pushed theadd_to_mcc_detect_and_infer_test branch 4 times, most recently fromcc8e881 to8ecd981CompareMarch 4, 2024 12:52
Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good in general. What if split the test on two: detector and infer separately. It's easier for debugging in case of an issue.

@AleksandrPanovAleksandrPanovforce-pushed theadd_to_mcc_detect_and_infer_test branch from8ecd981 to9cbea18CompareMarch 5, 2024 19:12
Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@AleksandrPanovAleksandrPanovforce-pushed theadd_to_mcc_detect_and_infer_test branch from9334e79 to18d2c29CompareMarch 6, 2024 08:52
Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@asmorkalovasmorkalov merged commit6b5142f intoopencv:4.xMar 7, 2024
@asmorkalovasmorkalov mentioned this pull requestApr 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

No one assigned

Labels

category: mcccolor calibration moduletest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AleksandrPanov@asmorkalov

[8]ページ先頭

©2009-2025 Movatter.jp