Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added getColorCharts()#3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 1 commit intoopencv:4.xfromAleksandrPanov:update_mcc_CCHecker
Mar 26, 2024

Conversation

@AleksandrPanov
Copy link
Contributor

@AleksandrPanovAleksandrPanov commentedFeb 29, 2024•
edited
Loading

merge this PR after#3647
Computes and returns the coordinates of the central parts of the charts modules.

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

TurboJonte reacted with thumbs up emoji
@AleksandrPanovAleksandrPanov added feature category: documentationDocumentation fix or update, does not affect code category: mcccolor calibration module labelsFeb 29, 2024
* and find by this the coordinates of the central parts of the charts modules.
* It is used in `cv::mcc::CCheckerDraw::draw()` and in `ChartsRGB` calculation.
*/
CV_WRAPvirtual std::vector<Point2f>getComputedCharts() = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

M.b.getColorCharts() is more relevant.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

MbgetComputedColorCharts()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I propose to name itgetColorCharts withoutcomputed. The function behaviour may change.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

@asmorkalov
Copy link
Contributor

Could you add the new method to test(s) and at least one of the samples.

@AleksandrPanov
Copy link
ContributorAuthor

AleksandrPanov commentedMar 3, 2024•
edited
Loading

Could you add the new method to test(s) and at least one of the samples.

MethodCCheckerDraw::draw() call methodgetColorCharts()andCCheckerDraw::draw() tested inCV_mccRunCCheckerDrawTest tests.

But now I'm adding a stronger test.

asmorkalov reacted with thumbs up emoji

@AleksandrPanovAleksandrPanov changed the titleadded getComputedCharts()added getComputedColorCharts()Mar 3, 2024
@AleksandrPanovAleksandrPanov marked this pull request as ready for reviewMarch 7, 2024 07:20
@AleksandrPanovAleksandrPanov changed the titleadded getComputedColorCharts()added getColorCharts()Mar 22, 2024
@AleksandrPanov
Copy link
ContributorAuthor

getColorCharts() tested in CV_mccRunCCheckerDrawTest tests, I don't think a special test is needed.

Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@asmorkalovasmorkalov merged commitc8c750a intoopencv:4.xMar 26, 2024
@asmorkalovasmorkalov self-assigned thisMar 26, 2024
@asmorkalovasmorkalov mentioned this pull requestApr 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

@asmorkalovasmorkalov

Labels

category: documentationDocumentation fix or update, does not affect codecategory: mcccolor calibration modulefeature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AleksandrPanov@asmorkalov
[8]ページ先頭
©2009-2025 Movatter.jp