Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

remove charuco duplication#3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@AleksandrPanov
Copy link
Contributor

@AleksandrPanovAleksandrPanov commentedJan 13, 2023•
edited
Loading

Removed charuco duplication after move aruco to main repo.

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanovAleksandrPanovforce-pushed theremove_duplication_from_aruco branch 2 times, most recently fromf467f0a to4b7d030CompareJanuary 13, 2023 09:12
@AleksandrPanovAleksandrPanovforce-pushed theremove_duplication_from_aruco branch from4b7d030 to10c188cCompareJanuary 16, 2023 00:08
@AleksandrPanovAleksandrPanov marked this pull request as ready for reviewJanuary 16, 2023 00:10
@asmorkalovasmorkalov self-requested a reviewJanuary 18, 2023 14:38
// get object and image points for the solvePnP function
Mat objPoints, imgPoints;
board->matchImagePoints(charucoCorners, charucoIds, objPoints, imgPoints);
solvePnP(objPoints, imgPoints, cameraMatrix, distCoeffs, rvec, tvec, useExtrinsicGuess);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

solvePnP throws exception, if there are no enough points.

AleksandrPanov reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

added points check:
if(charucoIds.getMat().total() < 4) return false;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I propose to add try-catch block and return false in case of exception. The function did not throw exceptions before and should not do it after the PR.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add try catch:

    try {        solvePnP(objPoints, imgPoints, cameraMatrix, distCoeffs, rvec, tvec, useExtrinsicGuess);    }    catch (const cv::Exception& e) {        CV_LOG_WARNING(NULL, "estimatePoseCharucoBoard: " << std::endl << e.what());        return false;    }

@asmorkalovasmorkalov self-assigned thisJan 23, 2023
@AleksandrPanovAleksandrPanovforce-pushed theremove_duplication_from_aruco branch from10c188c tofc0af69CompareJanuary 23, 2023 22:42
@AleksandrPanovAleksandrPanovforce-pushed theremove_duplication_from_aruco branch fromfc0af69 to1f713fbCompareJanuary 24, 2023 14:37
@asmorkalovasmorkalov merged commit529131e intoopencv:4.xJan 26, 2023
@alalekalalek mentioned this pull requestJan 28, 2023
@asmorkalovasmorkalov mentioned this pull requestMay 31, 2023
@rurban
Copy link

This caused a regression in interpolateCornersCharuco, which does not detect the markers anymore.
There need to be more testcases added, we can contribute some fromhttps://github.com/SpexAI/calibpy/
SeeSpexAI/calibpy#2

@asmorkalov
Copy link
Contributor

@AleksandrPanov could you take a look?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AleksandrPanov@rurban@asmorkalov@pingplug
[8]ページ先頭
©2009-2025 Movatter.jp