I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

alalek reviewed

Oct 26, 2021

View reviewed changes

modules/ximgproc/include/opencv2/ximgproc/hough_space_transform.hpp Outdated

		* with type CV_32SC1 by default.
		*
		*/
		CV_EXPORTS_W void HoughSpaceTransform(InputArray src,

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is wrong withHoughLines?

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

HoughLines only returns lines detected in images. Hough Space can be used in other ways like comparing similarity between images, and it has some advantages over comparing histograms or pixels directly.

Copy link

ContributorAuthor

kuloPoOct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After a search I found Hough Detection is using Radon Transform to detect shape in image. (Described herehttps://www.osti.gov/doepatents/biblio/4746348 ). What I implemented is more like Radon Transform (https://en.wikipedia.org/wiki/Radon_transform)
Should I change my function name and commit to the same pull request?

kuloPo requested a review fromalalek

October 28, 2021 05:52

asmorkalov requested a review fromAleksandrPanov

October 29, 2021 09:37

Copy link

Contributor

AleksandrPanov commentedNov 1, 2021•
edited
Loading

I compared the current version of Radon Transform with thescikit-image radon version based onscikit-image example.

The current version always crops the image when it is rotated.
The current version gives a slightly different result compared to the scikit-image version (this may be due to different interpolation or different rounding.). Need add more tests to check the meaning of the result (for example tests from radon.py.txt).
It might be helpful to addCV_32FC1 forsrc/dst.

radon.py.txt

kuloPo changed the title~~Add hough space transform function to ximgproc~~Add Radon transform function to ximgproc

Nov 7, 2021

Copy link

ContributorAuthor

kuloPo commentedNov 7, 2021•
edited
Loading

Updates:

Change function name to RadonTransform
Fix always cropping corner when rotate
transpose the output - now each column is the integral
add support for float number

The small difference may caused by:

rounding from rad to deg in scikit
different rotation method
copying image to a bigger background to capture the rotated image

I wrote two more cases to test data in corners
radon.py.txt

Copy link

Contributor

AleksandrPanov commentedNov 8, 2021•
edited
Loading

Thank you, I think it got better after your update:

:

Copy link

Contributor

AleksandrPanov commentedNov 8, 2021

LGTM + minor comments:

this patch should go into 4.x branch (only bug fixes get into 3.4 branch).
rebase your commits from 3.4 onto 4.x branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstream is configured by followingthis GitHub guide and fetched (git fetch upstream).
push rebased commits into source branch of your fork (with--force option)

Note: no need to re-open PR, apply changes "inplace".

kuloPoand others added12 commits

November 8, 2021 22:02

resolve rebash conflict

d3af10b

add test for hough_space_transform

db9dd78

add perf for hough_space_transform

6d3a090

add sample for hough_space_transform

ef201f7

fix compatible issue and trailing space

7c01f94

fix EOF issue

c65d6a7

resolve rebash conflict

a2cb365

update radon transform

88789d9

fix always cropping corner when rotatetranspose the output - now each column is integraladd support for float numberadd comment

add float type to perf test

7ab5b29

add float type to accu test

05eb729

update document

99cdad6

fix trailing space

36275ca

kuloPo force-pushed theadd-hough_space_transform branch from2a7f0ba to36275caCompare

November 8, 2021 22:22

kuloPo changed the base branch from3.4 to4.x

November 8, 2021 22:23

resolve rebase conflict

9d0b434

Copy link

ContributorAuthor

kuloPo commentedNov 8, 2021

The branch is rebased to 4.x

alalek reviewed

Nov 9, 2021

View reviewed changes

Copy link

Member

alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@kuloPo Thank you for updates!

Please take a look on the comments below.

modules/ximgproc/perf/perf_radon_transform.cpp Outdated

		namespace opencv_test {
		namespace {

		typedef tuple<Size, MatType> RadonTransformPerfTestParam;

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please avoid indentation in namespaces

modules/ximgproc/samples/radon_transform_demo.cpp Outdated


		int main() {
		cv::Mat src = cv::imread("peilin_plane.png", cv::IMREAD_GRAYSCALE);
		cv::Mat radon;

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please use 4 spaces for indentation (no tabs)

modules/ximgproc/samples/radon_transform_demo.cpp Outdated

		#include <opencv2/ximgproc/radon_transform.hpp>

		int main() {
		cv::Mat src = cv::imread("peilin_plane.png", cv::IMREAD_GRAYSCALE);

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cv::

In OpenCV samples we addusing namespace cv; after includes and removing allcv:: prefixes.

modules/ximgproc/test/test_radon_transform.cpp Outdated

		Mat radon;
		cv::ximgproc::RadonTransform(src, radon);

		ASSERT_EQ(radon.rows, 363);

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

_EQ

uses different order of parameters:(expected, actual).

Signature for_EQ isASSERT_EQ(expected_reference, actual_result);.
Correct order of parameters are required to emit valid error messages.

Reference:https://github.com/opencv/opencv/blob/4.0.0/modules/ts/include/opencv2/ts/ts_gtest.h#L8196-L8200

GTEST_API_ AssertionResult EqFailure(const char* expected_expression,                                     const char* actual_expression,                                     const std::string& expected_value,                                     const std::string& actual_value,                                     bool ignoring_case);

modules/ximgproc/perf/perf_radon_transform.cpp Outdated


		declare.in(src, WARMUP_RNG);

		TEST_CYCLE_N(3)

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TEST_CYCLE_N

is misused here. No need to specify amount of inner samples here.

Please use:

TEST_CYCLE()
orPERF_SAMPLE_BEGIN() +PERF_SAMPLE_END()

modules/ximgproc/test/test_radon_transform.cpp Outdated

		Mat radon;
		cv::ximgproc::RadonTransform(src, radon);

		ASSERT_EQ(radon.at<int>(0, 0), 0);

Copy link

Member

alalekNov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Before using.at<int> it makes sense to validate type.

ASSERT_EQ(CV_32SC1, radon.type());EXPECT_EQ(0, radon.at<int>(0, 0));

(prefer to useEXPECT_ for non-critical failures - e.g. code below would not crash)

Resolve coding style issues

7d08471

Copy link

ContributorAuthor

kuloPo commentedNov 9, 2021

All the issues are fixed.

AleksandrPanov approved these changes

Nov 9, 2021

View reviewed changes

Copy link

Contributor

AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

alalek assignedAleksandrPanov

Nov 9, 2021

alalek merged commite94ec40 intoopencv:4.x

Nov 9, 2021

alalek mentioned this pull request

Dec 30, 2021

(5.x) Merge 4.x#3142

Merged

alalek mentioned this pull request

Feb 22, 2022

(5.x) Merge 4.x#3179

Merged

mshabunin mentioned this pull request

Dec 6, 2024

Radon transform#549

Closed

Labels

category: ximgproc feature

Movatterモバイル変換

Add Radon transform function to ximgproc#3090

Add Radon transform function to ximgproc#3090

Uh oh!

Conversation

kuloPo commentedOct 26, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AleksandrPanov commentedNov 1, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

kuloPo commentedNov 7, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

AleksandrPanov commentedNov 8, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

AleksandrPanov commentedNov 8, 2021

Uh oh!

kuloPo commentedNov 8, 2021

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuloPo commentedNov 9, 2021

Uh oh!

AleksandrPanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kuloPo commentedOct 26, 2021•
edited
Loading

AleksandrPanov commentedNov 1, 2021•
edited
Loading

kuloPo commentedNov 7, 2021•
edited
Loading

AleksandrPanov commentedNov 8, 2021•
edited
Loading