- Notifications
You must be signed in to change notification settings - Fork5.9k
Added VTK 9 support#2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Added VTK 9 support#2549
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ocv_target_link_libraries(${the_module}PRIVATE${VTK_LIBRARIES}) | ||
| if (VTK_VERSIONVERSION_LESS"8.90.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lets make condition obvious?
if(COMMAND vtk_module_autoinit)- or
if(DEFINED VTK_USE_FILE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@alalek , this condition is used in official VTK samples (e.g.https://lorensen.github.io/VTKExamples/site/Cxx/SimpleOperations/DistanceBetweenPoints/#cmakeliststxt).
alalek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
mshabunin commentedJun 8, 2020
@alalek ,@asmorkalov , should we backport this patch to 3.4? |
* Added VTK 9 support* viz: tests are non-interactive now
Uh oh!
There was an error while loading.Please reload this page.
Relatedopencv/opencv#17431
Resolves#2555
Note: the code builds but does not work, additional investigation requiredPull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.