- Notifications
You must be signed in to change notification settings - Fork899
Use Numpy 2.0 for Python 3.9+ packages#1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -4,13 +4,9 @@ requires = [ | |||
| "numpy==1.13.3; python_version=='3.6' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | |||
| "numpy==1.17.0; python_version=='3.7' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | |||
| "numpy==1.17.5; python_version=='3.8' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | |||
| "numpy==1.19.3; python_version<='3.9' and sys_platform == 'linux' and platform_machine == 'aarch64'", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need explicit<2 insetup.py for Python 3.8 and earlier in case of possible expanding of numpy2 releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would clarify the actual state, but the current version works as well since numpy itself haspython_requires>=3.9, so numpy 2.0 and later cannot be installed with older Python versions.
The added constraints here look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
caldempsey commentedJun 17, 2024
🙏 |
cce7c99 intoopencv:4.xUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Numpy 2.0 is backward compatible with 1.x, but introduce several API and ABI changes. Numpy authors claim, that packages built against Numpy 2.0 should work with 1.x too. The PR introduce additional packages built with Python 3.9 and Numpy 2.0.
Numpy release details:https://github.com/numpy/numpy/releases/tag/v2.0.0
The PR differs from#1001. It builds packages with limited API cp37, but with Python 3.9 and Numpy 2.0. It's expected that the package should work with all supported Pythons 3.7+ and Numpy 1.x and 2.x.