Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
js: restore deep copy behavior for Mat.clone()#28216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
happy-capybara-man wants to merge1 commit intoopencv:4.xChoose a base branch
base:4.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+18 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emscripten 3.1.71+ introduced ClassHandle.clone() which performs a shallow copy.This shadowed the original OpenCV clone() method which was intended for deep copying.This patch:1. Hooks into onRuntimeInitialized in helpers.js2. Overrides cv.Mat.prototype.clone to point to mat_clone (deep copy)3. Updates JS tests to use clone() to verify the fix
Contributor
vrabaud commentedDec 18, 2025
I think it makes sense. Users will no more about OpenCV that emscripten and will therefore expect clone to behave like in C++. LGTM |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
In OpenCV.js,
cv.Mat.clone()may resolve to EmbindClassHandle.clone()(handle/shallow clone) instead of OpenCV deep copy.Changes
cv.Mat.prototype.clone->mat_cloneafter runtime initclone()Fixes#27572
Related: PR#26643 (js_clone_fix), PR#27985 (documentation update)
Verification
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.