Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #28089: BRISK compute() now respects provided keypoint orientations#28194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
priyanka-4112 wants to merge1 commit intoopencv:4.x
base:4.x
Choose a base branch
Loading
frompriyanka-4112:fix-brisk-orientation-28089

Conversation

@priyanka-4112
Copy link

Summary

Fixes#28089

BRISK'scompute() method was unconditionally recalculating keypoint orientations, ignoring pre-set angles. This fix checks if provided keypoints have valid angles (angle != -1) and only recalculates when needed.

Problem

  • BRISK ignored pre-set keypoint angles
  • Always recalculated orientation even when valid angles were provided
  • Resulted in identical descriptors for keypoints with different orientations

Solution

ModifiedBRISK_Impl::detectAndCompute() to:

  • Check if keypoints have valid angles before recalculating
  • Only compute orientation when angle == -1
  • Matches behavior of SIFT and ORB descriptors

Testing

  • Bug reproduced on Google Colab
  • Verified the logic follows the same pattern as other feature descriptors

asmorkalov reacted with thumbs up emoji
@asmorkalov
Copy link
Contributor

@priyanka-4112 Could you also add simple test that highlights the issue?

@asmorkalovasmorkalov added bug category: features2d pr: needs testNew functionality requires minimal tests set labelsDec 16, 2025
@asmorkalovasmorkalov self-requested a reviewDecember 16, 2025 08:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovAwaiting requested review from asmorkalov

Assignees

No one assigned

Labels

bugcategory: features2dpr: needs testNew functionality requires minimal tests set

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: cv2.BRISK_create().compute() unconditionally recalculates keypoint orientation.

2 participants

@priyanka-4112@asmorkalov

[8]ページ先頭

©2009-2025 Movatter.jp