Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed issues identified by PVS Studio#28185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 2 commits intoopencv:4.xfromasmorkalov:as/static_analysys_fix
Dec 18, 2025

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalovasmorkalov commentedDec 15, 2025•
edited
Loading

Partiallyfixes#28167
Paper:https://pvs-studio.com/en/blog/posts/cpp/1321/

Closed items: N2, N4, N5, N6, N7, N8, N10, N11, N13, N14.

To be continued...

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

uf->data[aroot].parent = broot;
uf->data[broot].size += asize;
return broot;
#defineDO_UNIONFIND(dx, dy)if (im.data[y*s + dy*s + x + dx] == v) connect(y*w + x, y*w + dy*w + x + dx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks likedo_line is only related toapriltag_quad_thresh.cpp implementation, why not keep it there as a free function acceptingUnionFind object by reference?

@asmorkalovasmorkalov merged commit721bb72 intoopencv:4.xDec 18, 2025
69 of 76 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@VadimLevinVadimLevinVadimLevin left review comments

@dkurtdkurtdkurt approved these changes

@opencv-alalekopencv-alalekAwaiting requested review from opencv-alalek

Assignees

@dkurtdkurt

Projects

None yet

Milestone

4.13.0

Development

Successfully merging this pull request may close these issues.

Bug report from static analysis

3 participants

@asmorkalov@VadimLevin@dkurt
[8]ページ先頭
©2009-2025 Movatter.jp