Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

dnn(tflite): add support for MAXIMUM layer#28171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ramukhsuya wants to merge6 commits intoopencv:4.x
base:4.x
Choose a base branch
Loading
fromramukhsuya:tflite-maximum-support

Conversation

@ramukhsuya
Copy link
Contributor

@ramukhsuyaramukhsuya commentedDec 13, 2025•
edited
Loading

Fixes#26433
This PR adds support for theMAXIMUM layer in the TFLite importer.
It maps the TFLiteMAXIMUM opcode to the existing OpenCV Element-wiseMax operation.

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

@dkurt Could you take a look?

@asmorkalovasmorkalov added the pr: needs testNew functionality requires minimal tests set labelDec 14, 2025
@asmorkalov
Copy link
Contributor

@ramukhsuya Could you create simple unit test for the enabled layer. You need to create small model with 1-2-3 layers (including Maxinum layer), submit it with reference input and output (generated with TFLite) to opencv_extra with the same branch name and add test code tohttps://github.com/opencv/opencv/blob/4.x/modules/dnn/test/test_tflite_importer.cpp

@ramukhsuya
Copy link
ContributorAuthor

Added a unit test for the layer and the TFLite model and .npy reference input and output files are uploaded to opencv_extra with the same branch name as requested

@ramukhsuyaramukhsuya marked this pull request as draftDecember 15, 2025 13:15
@ramukhsuyaramukhsuya marked this pull request as ready for reviewDecember 17, 2025 14:46
@asmorkalovasmorkalov removed the pr: needs testNew functionality requires minimal tests set labelDec 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov left review comments

@dkurtdkurtdkurt left review comments

Assignees

@dkurtdkurt

Projects

None yet

Milestone

4.13.0

Development

Successfully merging this pull request may close these issues.

dnn Tflite module SQUARED_DIFFERENCE, SUM, MAXIMUM, SQRT operands support

3 participants

@ramukhsuya@asmorkalov@dkurt
[8]ページ先頭
©2009-2025 Movatter.jp