Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
imgproc: upgrade warpPerspective precision and fix RISC-V accuracy regressions#28144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
satyam102006 wants to merge2 commits intoopencv:5.xChoose a base branch
base:5.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes accuracy regressions on RISC-V platforms for
warpPerspectiveandremapby upgrading the scalar fallback implementation to use double precision and enforcing its use on RISC-V.Related Issues
Fixes#27281
Fixes#27279
Detailed Description
The RISC-V optimized kernels (RVV) currently use single-precision floating-point logic (
v_float32). However, the OpenCV 5.x reference implementation requires double precisionto pass the strict accuracy tests.To provide a complete implementation fix without disabling optimizations for other platforms, I have modified modules/imgproc/src/warp_kernels.simd.hpp:
warpPerspective
Upgraded Scalar Loop: The internal scalar fallback loop was upgraded to use
doubleprecision variables and matrix coefficients to match the C++ reference implementation.nforced Fallback: The SIMD optimization path is explicitly disabled for RISC-V (
!defined(__riscv)). This forces execution to use the high-precision scalar loop.remap:
Disabled the RISC-V SIMD path (
!defined(__riscv)) to force fallback to the standard scalar implementation, preventing precision mismatches caused by vector floating-point logic.