Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
imgproc(ocl): Fix min_theta/max_theta handling in OpenCL HoughLines (Fixes #28036)#28097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
AKash-A007 wants to merge2 commits intoopencv:4.xChoose a base branch fromAKash-A007:fix-houghlines-ocl-minmax
base:4.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ughLines- Pass minTheta/maxTheta and corrected theta_step from C++ dispatcher- Modify OpenCL kernel to use angle = minTheta + idx * theta_step- Align OCL behavior with CPU HoughLinesStandard implementation- Add CPU vs OCL consistency testFixesopencv#28036
1d25aa6 toe818e2eComparee818e2e to07a3e22CompareContributorAuthor
AKash-A007 commentedDec 16, 2025
@asmorkalov Just a gentle reminder to review this PR whenever convenient. The fix aligns the OCL HoughLines behavior with the CPU implementation for restricted theta ranges. Appreciate your time! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OpenCL HoughLines incorrect theta range handling
The OpenCL implementation of cv::HoughLines was ignoring the user-provided
min_theta and max_theta range, always assuming a full [0, PI) span. This leads
to a mismatch between CPU and OCL results for limited-angle Hough transforms.
Changes in this PR
angle = minTheta + idx * theta_step
Why this matters
This bug caused incorrect results when using min_theta/max_theta on GPU via UMat.
This PR aligns OpenCL behavior with the CPU implementation and restores
correctness for limited-angle Hough transforms.
Issue
Fixes#28036
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.