Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix mesh loading for texture coordinates and face indices#25382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 20 commits intoopencv:5.xfromsavuor:rv/fix_mesh_load
Apr 16, 2024

Conversation

@savuor
Copy link
Contributor

@savuorsavuor commentedApr 10, 2024
edited
Loading

This PR changes

  • Texture coordinates were stored incorrectly (3-channel array is read as if there were 2 channels), fixed
  • Faces were pushed back to the output array instead of indexed writing which produced a lot of empty faces, fixed
  • A set of ground truth tests were added to cover these issues
  • std::vector<cv::Mat> support added forsaveMesh() which is required for Python bindings
  • More command line args were added to rasterization test data generator

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

2024-04-10T04:39:24.4511239Z ======================================================================2024-04-10T04:39:24.4513335Z FAIL: test_loadMesh (test_iomesh.raster_test)2024-04-10T04:39:24.4516024Z ----------------------------------------------------------------------2024-04-10T04:39:24.4518133Z Traceback (most recent call last):2024-04-10T04:39:24.4521164Z   File "/home/ci/opencv/modules/3d/misc/python/test/test_iomesh.py", line 36, in test_loadMesh2024-04-10T04:39:24.4525235Z     self.fail('texture coordinates array should be 1x18x2 or 18x1x2')2024-04-10T04:39:24.4528255Z AssertionError: texture coordinates array should be 1x18x2 or 18x1x22024-04-10T04:39:24.4530100Z 2024-04-10T04:39:24.4531218Z ----------------------------------------------------------------------

@asmorkalovasmorkalov self-requested a reviewApril 10, 2024 05:35
Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@asmorkalovasmorkalov self-assigned thisApr 16, 2024
@asmorkalovasmorkalov added this to the5.0 milestoneApr 16, 2024
@asmorkalovasmorkalov merged commit6699ca1 intoopencv:5.xApr 16, 2024
@savuorsavuor deleted the rv/fix_mesh_load branchApril 16, 2024 12:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@savuor@asmorkalov

[8]ページ先頭

©2009-2025 Movatter.jp