Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added test for YOLO NAS#24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 1 commit intoopencv:4.xfromAbdurrahheem:ash/yolo-nas-test
Jan 17, 2024
Merged

Conversation

@Abdurrahheem
Copy link
Contributor

@AbdurrahheemAbdurrahheem commentedJan 3, 2024•
edited by asmorkalov
Loading

This PR introduces a test for YOLO-NAS model.

Related PR in OpenCV Extra:opencv/opencv_extra#1141
Reference to theGitHub repository used for converting model to ONNX

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AbdurrahheemAbdurrahheem added the category:dnn_timvxTIM-VX related issues in DNN module labelJan 3, 2024
@AbdurrahheemAbdurrahheem self-assigned thisJan 3, 2024
@AbdurrahheemAbdurrahheem marked this pull request as ready for reviewJanuary 3, 2024 09:46
Copy link
Member

@fengyuentaufengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you provide links to the yolo-nas repo? I propose to add reference links as comments in the code to every yolo version if possible.

@fengyuentau
Copy link
Member

Also please submit a PR to opencv_extra to add yolo-nas model.

@asmorkalovasmorkalov added category: dnn (onnx)ONNX suport issues in DNN module test and removed category:dnn_timvxTIM-VX related issues in DNN module labelsJan 9, 2024
@asmorkalovasmorkalov added this to the4.10.0 milestoneJan 9, 2024
@asmorkalov
Copy link
Contributor

@opencv-alalek Please update test data on BuildBot.

opencv-alalek reacted with thumbs up emoji

@asmorkalovasmorkalov changed the titleAdded support for yolo nas testAdded test for YOLO NASJan 16, 2024
@asmorkalov
Copy link
Contributor

@Abdurrahheem I rebased your PR on top of 4.x to include Concat fix.

@asmorkalov
Copy link
Contributor

@fengyuentau@dkurt Could you take a look again. I fixed memory access issue reported by@opencv-alalek and added required references.

Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@opencv-alalekopencv-alalek removed their request for reviewJanuary 17, 2024 11:42
@asmorkalovasmorkalov merged commitd1e4bd8 intoopencv:4.xJan 17, 2024
@asmorkalovasmorkalov mentioned this pull requestJan 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fengyuentaufengyuentaufengyuentau left review comments

@opencv-alalekopencv-alalekopencv-alalek left review comments

@asmorkalovasmorkalovasmorkalov approved these changes

@dkurtdkurtdkurt approved these changes

Assignees

@AbdurrahheemAbdurrahheem

Labels

category: dnn (onnx)ONNX suport issues in DNN moduletest

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Abdurrahheem@fengyuentau@asmorkalov@dkurt@opencv-alalek
[8]ページ先頭
©2009-2025 Movatter.jp