Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable Android AAR package build with SDK project itself without Python#24752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@asmorkalov
Copy link
Contributor

  • Added JavaDoc package build and publishing
  • Added Source package build and publishing
  • More metadata for publishing
  • Disable native samples build with aar, because prefab is not complete yet

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
ContributorAuthor

@mshabunin@opencv-alalek please take a look.

Copy link
Contributor

@opencv-alalekopencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is lack of instructions how to validate the result.

@@ -0,0 +1,45 @@
#!/bin/bash -e
SDK_DIR=$1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

${1:?Required OpenCV Android SDK path} ?


echo "OpenCV Android SDK path: ${SDK_DIR}"

ANDROID_HOME=${ANDROID_HOME:-${ANDROID_SDK_ROOT:-${ANDROID_SDK?Required ANDROID_HOME/ANDROID_SDK/ANDROID_SDK_ROOT}}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Prefer using:? to avoid empty values too.

Details:https://tldp.org/LDP/abs/html/parameter-substitution.html

- Added JavaDoc package build and publishing- Added Source package build and publishing- More metadata for publishing- Disable native samples build with aar, because prefab is not complete yet
@asmorkalovasmorkalovforce-pushed theas/android_aar_with_gradle branch from1da8e1b tob59eca2CompareDecember 25, 2023 15:40
@asmorkalovasmorkalov merged commit4679284 intoopencv:4.xDec 25, 2023
@asmorkalovasmorkalov mentioned this pull requestJan 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@opencv-alalekopencv-alalekopencv-alalek approved these changes

@mshabuninmshabuninAwaiting requested review from mshabunin

Assignees

No one assigned

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov@opencv-alalek
[8]ページ先頭
©2009-2025 Movatter.jp