NotificationsYou must be signed in to change notification settings
Fork56.4k
Star85.3k

Fix OpenJPEG version in cmake scripts#24749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

asmorkalov merged 1 commit intoopencv:4.xfromFantasqueX:fix-openjpeg-version

Dec 22, 2023

Merged

Fix OpenJPEG version in cmake scripts#24749

asmorkalov merged 1 commit intoopencv:4.xfromFantasqueX:fix-openjpeg-version

Dec 22, 2023

Conversation

Copy link

Contributor

FantasqueX commentedDec 22, 2023•
edited
Loading

Currently, if OpenJPEG is found, only version information in summary is correct and the information right afterfind_package(OpenJPEG) is wrong.

-- Found system OpenJPEG: openjp2 (found version "")

The reason is OpenJPEGConfig.cmake only setsOPENJPEG_MAJOR_VERSION,OPENJPEG_MINOR_VERSION andOPENJPEG_BUILD_VERSION but notOPENJPEG_VERSION.

https://github.com/uclouvain/openjpeg/blob/master/cmake/OpenJPEGConfig.cmake.in

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Fix OpenJPEG version in cmake scripts

4ee4479

Currently, if OpenJPEG is found, only version information in summary iscorrect and the information right after `find_package(OpenJPEG)` iswrong.```-- Found system OpenJPEG: openjp2 (found version "")```The reason is OpenJPEGConfig.cmake only sets `OPENJPEG_MAJOR_VERSION`,`OPENJPEG_MINOR_VERSION` and `OPENJPEG_BUILD_VERSION` but not `OPENJPEG_VERSION`.