Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

try to enable Winograd by default in FP32 mode and disable it by default in FP16 mode#24709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 2 commits intoopencv:4.xfromvpisarev:winograd_mode
Dec 22, 2023

Conversation

@vpisarev
Copy link
Contributor

Hopefully, it will resolve regressions since 4.8.1 (see also#24587)

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu
Copy link
Member

zihaomu commentedDec 18, 2023•
edited
Loading

Hi@vpisarev, the default ofuseWinograd may not work. And I propose to add one more line code change like:https://github.com/opencv/opencv/pull/24587/files#r1403795553.

From:

useWinograd = params.get<bool>("use_winograd", true);

to

useWinograd = params.get<bool>("use_winograd", useWinograd);

So that, we could use the default ofuseWinograd to control the computation branch.

@vpisarev
Copy link
ContributorAuthor

Hi@vpisarev, the default ofuseWinograd may not work. And I propose to add one more line code change like:https://github.com/opencv/opencv/pull/24587/files#r1403795553.

From:

useWinograd = params.get<bool>("use_winograd", true);

to

useWinograd = params.get<bool>("use_winograd", useWinograd);

So that, we could use the default ofuseWinograd to control the computation branch.

done

Copy link
Member

@zihaomuzihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 👍

@asmorkalovasmorkalov added optimization platform: armARM boards related issues: RPi, NVIDIA TK/TX, etc labelsDec 18, 2023
@asmorkalovasmorkalov added this to the4.9.0 milestoneDec 18, 2023
@asmorkalovasmorkalov self-assigned thisDec 22, 2023
Copy link
Contributor

@asmorkalovasmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@asmorkalovasmorkalov merged commit853e5df intoopencv:4.xDec 22, 2023
@asmorkalovasmorkalov mentioned this pull requestJan 19, 2024
thewoz pushed a commit to thewoz/opencv that referenced this pull requestMay 29, 2024
Try to enable Winograd by default in FP32 mode and disable it by default in FP16 modeopencv#24709Hopefully, it will resolve regressions since 4.8.1 (see alsoopencv#24587)### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [ ] I agree to contribute to the project under Apache 2 License.- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [ ] The PR is proposed to the proper branch- [ ] There is a reference to the original bug report and related work- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable      Patch to opencv_extra has the same branch name.- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

@zihaomuzihaomuzihaomu approved these changes

Assignees

@asmorkalovasmorkalov

Labels

optimizationplatform: armARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vpisarev@zihaomu@asmorkalov
[8]ページ先頭
©2009-2025 Movatter.jp