Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix bug in ChessBoardDetector::cleanFoundConnectedQuads#24659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@MaximSmolskiy
Copy link
Contributor

Pull Request Readiness Checklist

We already havequad_count decrease inhttps://github.com/opencv/opencv/blob/4.x/modules/calib3d/src/calibinit.cpp#L1271 . So, we have double decrease each loop iteration and it isn't correct

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov and AleksandrPanov reacted with thumbs up emoji
Copy link
Contributor

@AleksandrPanovAleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PR was tested with OpenCVsynthetic benchmark.

There is no accuracy regressions.
image

👍

@AleksandrPanovAleksandrPanov removed their assignmentDec 12, 2023
@MaximSmolskiy
Copy link
ContributorAuthor

@asmorkalov Can you merge this PR please?

@asmorkalovasmorkalov merged commit509c1af intoopencv:4.xDec 19, 2023
@MaximSmolskiyMaximSmolskiy deleted the fix-bug-in-ChessBoardDetector-cleanFoundConnectedQuads branchDecember 19, 2023 13:10
@asmorkalovasmorkalov mentioned this pull requestJan 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AleksandrPanovAleksandrPanovAleksandrPanov approved these changes

Assignees

@AleksandrPanovAleksandrPanov

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy@AleksandrPanov@asmorkalov

[8]ページ先頭

©2009-2025 Movatter.jp