Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix fullscreen behavior for macOS#24098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom0xMihir:4.x
Sep 4, 2023
Merged

Conversation

@0xMihir
Copy link
Contributor

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

I'm opening this PR tofix#24097. Currently, this isn't ready to merge because there's still an issue that causes the title bar to take 1-2 seconds to hide. If anyone has any idea how to fix that, please let me know.

@asmorkalovasmorkalov added this to the4.9.0 milestoneAug 9, 2023
Copy link
Contributor

@VadimLevinVadimLevin left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

Please clean-up commented debugcout calls before merged.

I don't think that it is possible to get rid of the transition between normal and full-screen modes in macOS.

@0xMihir
Copy link
ContributorAuthor

@VadimLevin Should I delete the ones that were already there?

@VadimLevin
Copy link
Contributor

@VadimLevin Should I delete the ones that were already there?

Remove newly introduced ones only

opencv-alalek and 0xMihir reacted with thumbs up emoji

@0xMihir
Copy link
ContributorAuthor

Hey, I pushed the changes. Let me know if you need anything else before merging.

@asmorkalovasmorkalov merged commite274e72 intoopencv:4.xSep 4, 2023
@asmorkalovasmorkalov mentioned this pull requestSep 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@VadimLevinVadimLevinVadimLevin approved these changes

Assignees

@VadimLevinVadimLevin

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

macOS Fullscreen broken

3 participants

@0xMihir@VadimLevin@asmorkalov
[8]ページ先頭
©2009-2025 Movatter.jp